Skip to content

Commit c0de8e1

Browse files
feat(select): Introduce 'menuPlacement=auto' by default for all selects (#102067)
Recently, we decided to introduce the prop menuPlacement="auto" as the default behavior for ReactSelect ([see](#100658)). However, I noticed through the [PR](#101403 (comment)) that this default was not being applied when the component was a CreatableSelect. This PR fixes that issue, making `menuPlacement="auto"` the default for all select components.
1 parent ac8e7fe commit c0de8e1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

static/app/components/core/select/select.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ function SelectPicker<OptionType extends OptionTypeBase>({
534534
Component = ReactSelect;
535535
}
536536

537-
return <Component ref={ref as any} {...props} />;
537+
return <Component ref={ref as any} {...props} menuPlacement="auto" />;
538538
}
539539

540540
// XXX (tkdodo): this type assertion is a leftover from when we had forwardRef

0 commit comments

Comments
 (0)