Add SOPS_GCP_KMS_CLIENT_TYPE environment variable support #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows users to select between gRPC and REST clients for GCP KMS by setting the SOPS_GCP_KMS_CLIENT_TYPE environment variable. - Default: gRPC client (when not set or set to 'grpc') - REST client: when set to 'rest' - Updated documentation Fixes getsops#1570） Signed-off-by: shin.fukami.nd <[email protected]>
putsuka
changed the title
|
@felixfontein |
|
I don't know, I've requested a review from the maintainer group since I don't feel confident enough to review this one. |
Thank you. I hope it gets reviewed and merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SOPS_GCP_KMS_CLIENT_TYPE environment variable support
Summary
This PR adds support for selecting GCP KMS client type (gRPC or REST) via the
SOPS_GCP_KMS_CLIENT_TYPEenvironment variable.Motivation
Currently, the client type is hardcoded, making it difficult to integrate with different environments. This change provides flexibility while maintaining backward compatibility. Additionally, selecting the REST client can help avoid errors that occur when SOPS operates through a VPN, addressing the issues outlined in issue #1570 .
Changes
SOPS_GCP_KMS_CLIENT_TYPEenvironment variable supportBackward Compatibility