@@ -5110,7 +5110,7 @@ static const ggml_type other_types[] = {
5110
5110
};
5111
5111
5112
5112
// Test cases for evaluation: should try to cover edge cases while using small input sizes to keep the runtime low
5113
- static std::vector<std::unique_ptr<test_case>> make_test_cases_eval (bool test_sgd = true ) {
5113
+ static std::vector<std::unique_ptr<test_case>> make_test_cases_eval () {
5114
5114
std::vector<std::unique_ptr<test_case>> test_cases;
5115
5115
std::default_random_engine rng (0 );
5116
5116
@@ -5912,8 +5912,7 @@ static std::vector<std::unique_ptr<test_case>> make_test_cases_eval(bool test_sg
5912
5912
test_cases.emplace_back (new test_cross_entropy_loss_back (GGML_TYPE_F32, {30000 , 1 , 1 , 1 }));
5913
5913
5914
5914
test_cases.emplace_back (new test_opt_step_adamw (GGML_TYPE_F32, {10 , 5 , 4 , 3 }));
5915
- if (test_sgd)
5916
- test_cases.emplace_back (new test_opt_step_sgd (GGML_TYPE_F32, { 10 , 5 , 4 , 3 }));
5915
+ test_cases.emplace_back (new test_opt_step_sgd (GGML_TYPE_F32, { 10 , 5 , 4 , 3 }));
5917
5916
5918
5917
#if 0
5919
5918
// these tests are disabled to save execution time, sbut they can be handy for debugging
@@ -6051,10 +6050,6 @@ static bool test_backend(ggml_backend_t backend, test_mode mode, const char * op
6051
6050
}
6052
6051
};
6053
6052
6054
- char const * name = ggml_backend_name (backend);
6055
- bool const vulkan = strstr (name, " ulkan" );
6056
- bool const sgd = !vulkan;
6057
-
6058
6053
if (mode == MODE_TEST) {
6059
6054
auto test_cases = make_test_cases_eval ();
6060
6055
filter_test_cases (test_cases, params_filter);
@@ -6080,7 +6075,7 @@ static bool test_backend(ggml_backend_t backend, test_mode mode, const char * op
6080
6075
}
6081
6076
6082
6077
if (mode == MODE_GRAD) {
6083
- auto test_cases = make_test_cases_eval (sgd );
6078
+ auto test_cases = make_test_cases_eval ();
6084
6079
filter_test_cases (test_cases, params_filter);
6085
6080
size_t n_ok = 0 ;
6086
6081
for (auto & test : test_cases) {
0 commit comments