perf: replace preload with joins #19

Author: ayaanqui

src/services/category_service.go

@@ -25,7 +25,7 @@ func (service *CategoryService) Create(input *types.CreateCategory, output *type
 func (service *CategoryService) Find(name string, output *types.Category) error {
 	return service.DB.
 		Table(service.TABLE).
-		Where("name = ?", name).
+		Where("categories.name = ?", name).
 		First(output).
 		Error
 }

src/services/event_service.go

@@ -123,7 +123,7 @@ func (service *EventService) FindAllForUser(user *types.User, output *[]types.Ev
 		Table(service.TABLE).
 		Joins("CreatedBy").
 		Joins("ModifiedBy").
-		Where("created_by_id = ?", user_id).
+		Where("events.created_by_id = ?", user_id).
 		Find(output).
 		Error
 }

src/services/product_service.go

@@ -53,7 +53,7 @@ func (service *ProductService) Find(key string, output *types.Product) error {
 	id, _ := uuid.Parse(key)
 	return service.DB.
 		Table(service.TABLE).
-		Preload("Category").
+		Joins("Category").
 		Where("products.product_key = ? OR products.id = ?", key, id).
 		First(output).
 		Error
@@ -128,21 +128,21 @@ func (service *ProductService) Search(filter types.ProductFilter) (*[]types.Prod
 
 	if filter.MinPrice > 0 || filter.MaxPrice > 0 {
 		query.
-			Where("price BETWEEN ? AND ?", filter.MinPrice, filter.MaxPrice)
+			Where("products.price BETWEEN ? AND ?", filter.MinPrice, filter.MaxPrice)
 	}
 
 	switch filter.Sort {
 	case "rating":
-		query.Order("rating DESC")
+		query.Order("products.rating DESC")
 	case "price":
-		query.Order("price DESC")
+		query.Order("products.price DESC")
 	case "totalReviews":
-		query.Order("total_reviews DESC")
+		query.Order("products.total_reviews DESC")
 	default:
-		query.Order("updated_at DESC")
+		query.Order("products.updated_at DESC")
 	}
 	err := query.
-		Preload("Category").
+		Joins("Category").
 		Find(products).
 		Error
 	return products, err

src/services/user_service.go

@@ -11,31 +11,31 @@ type UserService struct {
 func (service *UserService) FindByEmail(email string, output *types.User) error {
 	return service.DB.
 		Table(service.TABLE).
-		Where("email = ?", email).
+		Where("users.email = ?", email).
 		First(output).
 		Error
 }
 
 func (service *UserService) FindById(id string, output *types.User) error {
 	return service.DB.
 		Table(service.TABLE).
-		Where("id = ?", id).
+		Where("users.id = ?", id).
 		First(output).
 		Error
 }
 
 func (service *UserService) FindByIdAndEmail(id string, email string, output *types.User) error {
 	return service.DB.
 		Table(service.TABLE).
-		Where("id = ? AND email = ?", id, email).
+		Where("users.id = ? AND users.email = ?", id, email).
 		First(output).
 		Error
 }
 
 func (service *UserService) FindByIdOrEmail(id string, email string, output *types.User) error {
 	return service.DB.
 		Table(service.TABLE).
-		Where("id = ? OR email = ?", id, email).
+		Where("users.id = ? OR users.email = ?", id, email).
 		First(output).
 		Error
 }
@@ -69,7 +69,7 @@ func (service *UserService) Create(input *types.CreateUser, output *types.User)
 func (service *UserService) DeleteById(key string) error {
 	return service.DB.
 		Table(service.TABLE).
-		Where("id = ?", key).
+		Where("users.id = ?", key).
 		Delete(&types.User{}).
 		Error
 }