Remove windows-setup auto download functionality #1660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrorijo91
approved these changes
Dec 28, 2021
Member
pedrorijo91
left a comment
pedrorijo91
left a comment
There was a problem hiding this comment.
sorry for taking some time, but overall this LGTM
Member
|
if anyone with windows machine can test things look good as well it would be great. this version is deployed at https://git-scm-pr-1660.herokuapp.com/download/win |
Contributor
Author
|
@pedrorijo91 Thanks for merging PR. Was this function written for Windows page? |
Member
|
seems to have been introduced at #1418 |
Contributor
Author
|
It seems that we don't need that method now ? Apart from this, what if we increase the font-weight of |
Member
|
i guess we can remove it yes! regarding the font-weight, i'd say to feel free to submit a PR and we can see how it looks on the deployment! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.jsfile.Context
CC: #1655 (comment)