Skip to content

Commit da43015

Browse files
mmontalboclaude
andcommitted
t4211: document why pickaxe commit-level filtering remains broken
Add a comment above the test_expect_failure tests explaining that show_log() prints the commit header before diffcore_std() runs pickaxe, so commits cannot be suppressed even when no diff pairs survive filtering. Fixing this would require deferring show_log() until after diffcore_std(), which is a larger restructuring of the log-tree output pipeline. Signed-off-by: Michael Montalbo <mmontalbo@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 0d3e84a commit da43015

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

t/t4211-line-log.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -494,6 +494,12 @@ test_expect_success '-L --find-object does not crash with merge and rename' '
494494
--find-object=$(git rev-parse HEAD:file) >actual
495495
'
496496

497+
# Commit-level filtering with pickaxe does not yet work for -L.
498+
# show_log() prints the commit header before diffcore_std() runs
499+
# pickaxe, so commits cannot be suppressed even when no diff pairs
500+
# survive filtering. Fixing this would require deferring show_log()
501+
# until after diffcore_std(), which is a larger restructuring of the
502+
# log-tree output pipeline.
497503
test_expect_failure '-L -G should filter commits by pattern' '
498504
git log --format="%s" --no-patch -L 1,1:file -G "nomatch" >actual &&
499505
test_must_be_empty actual

0 commit comments

Comments
 (0)