fix(compute-providers): make metadata cleanup idempotent

Author: edersonbrilhante

lambdas/libs/compute-providers/aws/microvm/src/control-plane/runner-metadata.test.ts

@@ -175,6 +175,38 @@ describe('MicroVM metadata lifecycle', () => {
     ]);
   });
 
+  it('continues deleting metadata when optional parameters are already absent', async () => {
+    vi.mocked(deleteParameter)
+      .mockRejectedValueOnce(
+        Object.assign(new Error('ParameterNotFound'), {
+          __type: 'ParameterNotFound',
+          $fault: 'client',
+          $metadata: { httpStatusCode: 400 },
+        }),
+      )
+      .mockRejectedValueOnce(Object.assign(new Error('missing parameter'), { name: 'ParameterNotFound' }));
+
+    await expect(deleteMicrovmRunnerMetadata(metadataSsmPath, 'mvm-1')).resolves.toBeUndefined();
+    expect(vi.mocked(deleteParameter).mock.calls.map(([name]) => name)).toEqual([
+      `${metadataSsmPath}/mvm-1.github-runner-id`,
+      `${metadataSsmPath}/mvm-1.orphan`,
+      `${metadataSsmPath}/mvm-1.cleanup-requested-at`,
+      `${metadataSsmPath}/mvm-1`,
+    ]);
+  });
+
+  it('propagates metadata deletion failures other than missing parameters', async () => {
+    const error = Object.assign(new Error('AccessDeniedException'), {
+      __type: 'AccessDeniedException',
+      $fault: 'client',
+      $metadata: { httpStatusCode: 400 },
+    });
+    vi.mocked(deleteParameter).mockRejectedValueOnce(error);
+
+    await expect(deleteMicrovmRunnerMetadata(metadataSsmPath, 'mvm-1')).rejects.toBe(error);
+    expect(deleteParameter).toHaveBeenCalledTimes(1);
+  });
+
   it('returns tracked and state-only active cleanup requests for termination retry', async () => {
     vi.mocked(getParametersByPath).mockResolvedValue(
       new Map([

lambdas/libs/compute-providers/aws/microvm/src/control-plane/runner-metadata.ts

@@ -88,6 +88,13 @@ function isRecord(value: unknown): value is Record<string, unknown> {
   return typeof value === 'object' && value !== null && !Array.isArray(value);
 }
 
+function isParameterNotFound(error: unknown): boolean {
+  return (
+    error instanceof Error &&
+    (error.name === 'ParameterNotFound' || ('__type' in error && error.__type === 'ParameterNotFound'))
+  );
+}
+
 function optionalString(value: unknown): value is string | undefined {
   return value === undefined || (typeof value === 'string' && value.length > 0);
 }
@@ -342,7 +349,7 @@ export async function deleteMicrovmRunnerMetadata(metadataSsmPath: string, micro
     try {
       await deleteParameter(parameterName);
     } catch (error) {
-      if (!(error instanceof Error && error.name === 'ParameterNotFound')) throw error;
+      if (!isParameterNotFound(error)) throw error;
     }
   }
 }