Skip to content

Commit 547e232

Browse files
authored
Merge pull request #18174 from github/redsun82/rust-tweaks
Rust: rename `TypeRef` and `*Type` to `*TypeRepr`, `ty` to `type_repr`, and expand some abbreviations in generated docs
2 parents 801f696 + 5350300 commit 547e232

File tree

367 files changed

+3367
-3248
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

367 files changed

+3367
-3248
lines changed

misc/codegen/generators/qlgen.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ class NoClasses(Error):
6464
"int": "integer",
6565
"var": "variable",
6666
"ref": "reference",
67+
"pat": "pattern",
6768
}
6869

6970
abbreviations.update({f"{k}s": f"{v}s" for k, v in abbreviations.items()})

rust/ast-generator/src/main.rs

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,15 @@ fn project_root() -> PathBuf {
1515
}
1616

1717
fn class_name(type_name: &str) -> String {
18-
let name = match type_name {
19-
"BinExpr" => "BinaryExpr",
20-
"ElseBranch" => "Expr",
21-
"Fn" => "Function",
22-
"Literal" => "LiteralExpr",
23-
"Type" => "TypeRef",
24-
"ArrayExpr" => "ArrayExprInternal",
25-
_ => type_name,
26-
};
27-
name.to_owned()
18+
match type_name {
19+
"BinExpr" => "BinaryExpr".to_owned(),
20+
"ElseBranch" => "Expr".to_owned(),
21+
"Fn" => "Function".to_owned(),
22+
"Literal" => "LiteralExpr".to_owned(),
23+
"ArrayExpr" => "ArrayExprInternal".to_owned(),
24+
_ if type_name.ends_with("Type") => format!("{}Repr", type_name),
25+
_ => type_name.to_owned(),
26+
}
2827
}
2928

3029
fn property_name(type_name: &str, field_name: &str) -> String {
@@ -35,6 +34,8 @@ fn property_name(type_name: &str, field_name: &str) -> String {
3534
("Path", "segment") => "part",
3635
(_, "then_branch") => "then",
3736
(_, "else_branch") => "else_",
37+
("ArrayType", "ty") => "element_type_repr",
38+
(_, "ty") => "type_repr",
3839
_ => field_name,
3940
};
4041
name.to_owned()

rust/extractor/src/generated/.generated.list

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)