Merge pull request #19560 from owen-mc/java/add-stringreplaceallwithnonregex-test

owen-mc · web-flow · commit 8b68d95231b2 · 2025-05-22T15:07:58.000+01:00
Java: Add test showing correct usage
diff --git a/java/ql/src/Performance/StringReplaceAllWithNonRegex.md b/java/ql/src/Performance/StringReplaceAllWithNonRegex.md
@@ -18,6 +18,7 @@ public class Test {
         String s1 = "test";
         s1 = s1.replaceAll("t", "x"); // NON_COMPLIANT
         s1 = s1.replaceAll(".*", "x"); // COMPLIANT
+        s1 = s1.replace("t", "x"); // COMPLIANT
     }
 }
 
diff --git a/java/ql/test/query-tests/StringReplaceAllWithNonRegex/Test.java b/java/ql/test/query-tests/StringReplaceAllWithNonRegex/Test.java
@@ -3,5 +3,6 @@ void f() {
         String s1 = "test";
         s1 = s1.replaceAll("t", "x"); // $ Alert // NON_COMPLIANT
         s1 = s1.replaceAll(".*", "x"); // COMPLIANT
+        s1 = s1.replace("t", "x"); // COMPLIANT
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ public class Test {`
`18`	`18`	`String s1 = "test";`
`19`	`19`	`s1 = s1.replaceAll("t", "x"); // NON_COMPLIANT`
`20`	`20`	`s1 = s1.replaceAll(".*", "x"); // COMPLIANT`
	`21`	`+ s1 = s1.replace("t", "x"); // COMPLIANT`
`21`	`22`	`}`
`22`	`23`	`}`
`23`	`24`
Original file line number	Diff line number	Diff line change
`@@ -3,5 +3,6 @@ void f() {`
`3`	`3`	`String s1 = "test";`
`4`	`4`	`s1 = s1.replaceAll("t", "x"); // $ Alert // NON_COMPLIANT`
`5`	`5`	`s1 = s1.replaceAll(".*", "x"); // COMPLIANT`
	`6`	`+ s1 = s1.replace("t", "x"); // COMPLIANT`
`6`	`7`	`}`
`7`	`8`	`}`