JS: removed unnecessary getALocalSource from ArrayCallBackDataTaintStep

Napalys · Napalys · commit 9dbf7d1828b2 · 2024-11-20T14:54:06.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/Arrays.qll b/javascript/ql/lib/semmle/javascript/Arrays.qll
@@ -505,7 +505,7 @@ private module ArrayLibraries {
     override predicate step(DataFlow::Node obj, DataFlow::Node element) {
       exists(DataFlow::MethodCallNode call |
         call.getMethodName() = ["findLast", "find", "findLastIndex"] and
-        obj = call.getReceiver().getALocalSource() and
+        obj = call.getReceiver() and
         element = call.getCallback(0).getParameter(0)
       )
     }

Original file line number	Diff line number	Diff line change
`@@ -505,7 +505,7 @@ private module ArrayLibraries {`
`505`	`505`	`override predicate step(DataFlow::Node obj, DataFlow::Node element) {`
`506`	`506`	`exists(DataFlow::MethodCallNode call \|`
`507`	`507`	`call.getMethodName() = ["findLast", "find", "findLastIndex"] and`
`508`		`- obj = call.getReceiver().getALocalSource() and`
	`508`	`+ obj = call.getReceiver() and`
`509`	`509`	`element = call.getCallback(0).getParameter(0)`
`510`	`510`	`)`
`511`	`511`	`}`