Skip to content

Conversation

egregius313
Copy link
Contributor

Adds models for NavigationManager::NavigateTo and the GetUriWithQueryParameter method. This will make the cs/web/unvalidated-url-redirection query Blazor-aware.

This is in draft until dataflow for Blazor is merged.

Pull Request checklist

All query authors

Internal query authors only

- [ ] Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).

Copy link
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    Others,"``Amazon.Lambda.APIGatewayEvents``, ``Amazon.Lambda.Core``, ``Dapper``, ``ILCompiler``, ``ILLink.RoslynAnalyzer``, ``ILLink.Shared``, ``ILLink.Tasks``, ``Internal.IL``, ``Internal.Pgo``, ``Internal.TypeSystem``, ``JsonToItemsTaskFactory``, ``Microsoft.Android.Build``, ``Microsoft.Apple.Build``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.AspNetCore.Components``, ``Microsoft.AspNetCore.Mvc``, ``Microsoft.AspNetCore.WebUtilities``, ``Microsoft.CSharp``, ``Microsoft.Diagnostics.Tools.Pgo``, ``Microsoft.DotNet.Build.Tasks``, ``Microsoft.DotNet.PlatformAbstractions``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.Diagnostics.Metrics``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.JSInterop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NET.Sdk.WebAssembly``, ``Microsoft.NET.WebAssembly.Webcil``, ``Microsoft.VisualBasic``, ``Microsoft.WebAssembly.Build.Tasks``, ``Microsoft.Win32``, ``Mono.Linker``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``SourceGenerators``, ``Windows.Security.Cryptography.Core``",59,2074,152,4
+    Others,"``Amazon.Lambda.APIGatewayEvents``, ``Amazon.Lambda.Core``, ``Dapper``, ``ILCompiler``, ``ILLink.RoslynAnalyzer``, ``ILLink.Shared``, ``ILLink.Tasks``, ``Internal.IL``, ``Internal.Pgo``, ``Internal.TypeSystem``, ``JsonToItemsTaskFactory``, ``Microsoft.Android.Build``, ``Microsoft.Apple.Build``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.AspNetCore.Components``, ``Microsoft.AspNetCore.Mvc``, ``Microsoft.AspNetCore.WebUtilities``, ``Microsoft.CSharp``, ``Microsoft.Diagnostics.Tools.Pgo``, ``Microsoft.DotNet.Build.Tasks``, ``Microsoft.DotNet.PlatformAbstractions``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.Diagnostics.Metrics``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.JSInterop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NET.Sdk.WebAssembly``, ``Microsoft.NET.WebAssembly.Webcil``, ``Microsoft.VisualBasic``, ``Microsoft.WebAssembly.Build.Tasks``, ``Microsoft.Win32``, ``Mono.Linker``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``SourceGenerators``, ``Windows.Security.Cryptography.Core``",59,2077,154,4
-    Totals,,106,12900,400,9
+    Totals,,106,12903,402,9
  • Changes to framework-coverage-csharp.csv:
- package,sink,source,summary,sink:code-injection,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:file-content-store,sink:html-injection,sink:js-injection,sink:log-injection,sink:sql-injection,source:commandargs,source:database,source:environment,source:file,source:file-write,source:remote,source:stdin,source:windows-registry,summary:taint,summary:value
+ package,sink,source,summary,sink:code-injection,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:file-content-store,sink:html-injection,sink:js-injection,sink:log-injection,sink:sql-injection,sink:url-redirection,source:commandargs,source:database,source:environment,source:file,source:file-write,source:remote,source:stdin,source:windows-registry,summary:taint,summary:value
- Amazon.Lambda.APIGatewayEvents,,6,,,,,,,,,,,,,,,,,6,,,,
+ Amazon.Lambda.APIGatewayEvents,,6,,,,,,,,,,,,,,,,,,6,,,,
- Amazon.Lambda.Core,10,,,,,,,,,,,10,,,,,,,,,,,
+ Amazon.Lambda.Core,10,,,,,,,,,,,10,,,,,,,,,,,,
- Dapper,55,42,1,,,,,,,,,,55,,42,,,,,,,,1
+ Dapper,55,42,1,,,,,,,,,,55,,,42,,,,,,,,1
- ILCompiler,,,123,,,,,,,,,,,,,,,,,,,79,44
+ ILCompiler,,,123,,,,,,,,,,,,,,,,,,,,79,44
- ILLink.RoslynAnalyzer,,,139,,,,,,,,,,,,,,,,,,,50,89
+ ILLink.RoslynAnalyzer,,,139,,,,,,,,,,,,,,,,,,,,50,89
- ILLink.Shared,,,31,,,,,,,,,,,,,,,,,,,11,20
+ ILLink.Shared,,,31,,,,,,,,,,,,,,,,,,,,11,20
- ILLink.Tasks,,,5,,,,,,,,,,,,,,,,,,,4,1
+ ILLink.Tasks,,,5,,,,,,,,,,,,,,,,,,,,4,1
- Internal.IL,,,54,,,,,,,,,,,,,,,,,,,28,26
+ Internal.IL,,,54,,,,,,,,,,,,,,,,,,,,28,26
- Internal.Pgo,,,9,,,,,,,,,,,,,,,,,,,2,7
+ Internal.Pgo,,,9,,,,,,,,,,,,,,,,,,,,2,7
- Internal.TypeSystem,,,329,,,,,,,,,,,,,,,,,,,201,128
+ Internal.TypeSystem,,,329,,,,,,,,,,,,,,,,,,,,201,128
- JsonToItemsTaskFactory,,,11,,,,,,,,,,,,,,,,,,,1,10
+ JsonToItemsTaskFactory,,,11,,,,,,,,,,,,,,,,,,,,1,10
- Microsoft.Android.Build,,1,14,,,,,,,,,,,,,1,,,,,,12,2
+ Microsoft.Android.Build,,1,14,,,,,,,,,,,,,,1,,,,,,12,2
- Microsoft.Apple.Build,,,7,,,,,,,,,,,,,,,,,,,7,
+ Microsoft.Apple.Build,,,7,,,,,,,,,,,,,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,,,28,,,,,,,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,,,28,,,,,,,,,,,
- Microsoft.AspNetCore.Components,2,2,2,,,,,,,2,,,,,,,,,2,,,1,1
+ Microsoft.AspNetCore.Components,4,2,5,,,,,,,2,,,,2,,,,,,2,,,4,1
- Microsoft.AspNetCore.Mvc,,,2,,,,,,,,,,,,,,,,,,,,2
+ Microsoft.AspNetCore.Mvc,,,2,,,,,,,,,,,,,,,,,,,,,2
- Microsoft.AspNetCore.WebUtilities,,,2,,,,,,,,,,,,,,,,,,,2,
+ Microsoft.AspNetCore.WebUtilities,,,2,,,,,,,,,,,,,,,,,,,,2,
- Microsoft.CSharp,,,2,,,,,,,,,,,,,,,,,,,2,
+ Microsoft.CSharp,,,2,,,,,,,,,,,,,,,,,,,,2,
- Microsoft.Diagnostics.Tools.Pgo,,,25,,,,,,,,,,,,,,,,,,,2,23
+ Microsoft.Diagnostics.Tools.Pgo,,,25,,,,,,,,,,,,,,,,,,,,2,23
- Microsoft.DotNet.Build.Tasks,,,10,,,,,,,,,,,,,,,,,,,8,2
+ Microsoft.DotNet.Build.Tasks,,,10,,,,,,,,,,,,,,,,,,,,8,2
- Microsoft.DotNet.PlatformAbstractions,,,1,,,,,,,,,,,,,,,,,,,1,
+ Microsoft.DotNet.PlatformAbstractions,,,1,,,,,,,,,,,,,,,,,,,,1,
- Microsoft.EntityFrameworkCore,6,,12,,,,,,,,,,6,,,,,,,,,,12
+ Microsoft.EntityFrameworkCore,6,,12,,,,,,,,,,6,,,,,,,,,,,12
- Microsoft.Extensions.Caching.Distributed,,,3,,,,,,,,,,,,,,,,,,,,3
+ Microsoft.Extensions.Caching.Distributed,,,3,,,,,,,,,,,,,,,,,,,,,3
- Microsoft.Extensions.Caching.Memory,,,37,,,,,,,,,,,,,,,,,,,5,32
+ Microsoft.Extensions.Caching.Memory,,,37,,,,,,,,,,,,,,,,,,,,5,32
- Microsoft.Extensions.Configuration,,3,101,,,,,,,,,,,,,3,,,,,,29,72
+ Microsoft.Extensions.Configuration,,3,101,,,,,,,,,,,,,,3,,,,,,29,72
- Microsoft.Extensions.DependencyInjection,,,202,,,,,,,,,,,,,,,,,,,15,187
+ Microsoft.Extensions.DependencyInjection,,,202,,,,,,,,,,,,,,,,,,,,15,187
- Microsoft.Extensions.DependencyModel,,1,16,,,,,,,,,,,,,1,,,,,,14,2
+ Microsoft.Extensions.DependencyModel,,1,16,,,,,,,,,,,,,,1,,,,,,14,2
- Microsoft.Extensions.Diagnostics.Metrics,,,14,,,,,,,,,,,,,,,,,,,1,13
+ Microsoft.Extensions.Diagnostics.Metrics,,,14,,,,,,,,,,,,,,,,,,,,1,13
- Microsoft.Extensions.FileProviders,,,17,,,,,,,,,,,,,,,,,,,7,10
+ Microsoft.Extensions.FileProviders,,,17,,,,,,,,,,,,,,,,,,,,7,10
- Microsoft.Extensions.FileSystemGlobbing,,,21,,,,,,,,,,,,,,,,,,,10,11
+ Microsoft.Extensions.FileSystemGlobbing,,,21,,,,,,,,,,,,,,,,,,,,10,11
- Microsoft.Extensions.Hosting,,,58,,,,,,,,,,,,,,,,,,,29,29
+ Microsoft.Extensions.Hosting,,,58,,,,,,,,,,,,,,,,,,,,29,29
- Microsoft.Extensions.Http,,,9,,,,,,,,,,,,,,,,,,,7,2
+ Microsoft.Extensions.Http,,,9,,,,,,,,,,,,,,,,,,,,7,2
- Microsoft.Extensions.Logging,,,91,,,,,,,,,,,,,,,,,,,25,66
+ Microsoft.Extensions.Logging,,,91,,,,,,,,,,,,,,,,,,,,25,66
- Microsoft.Extensions.Options,,,68,,,,,,,,,,,,,,,,,,,44,24
+ Microsoft.Extensions.Options,,,68,,,,,,,,,,,,,,,,,,,,44,24
- Microsoft.Extensions.Primitives,,,73,,,,,,,,,,,,,,,,,,,67,6
+ Microsoft.Extensions.Primitives,,,73,,,,,,,,,,,,,,,,,,,,67,6
- Microsoft.Interop,,,159,,,,,,,,,,,,,,,,,,,75,84
+ Microsoft.Interop,,,159,,,,,,,,,,,,,,,,,,,,75,84
- Microsoft.JSInterop,2,,,,,,,,,,2,,,,,,,,,,,,
+ Microsoft.JSInterop,2,,,,,,,,,,2,,,,,,,,,,,,,
- Microsoft.NET.Build.Tasks,,,5,,,,,,,,,,,,,,,,,,,3,2
+ Microsoft.NET.Build.Tasks,,,5,,,,,,,,,,,,,,,,,,,,3,2
- Microsoft.NET.Sdk.WebAssembly,,,2,,,,,,,,,,,,,,,,,,,1,1
+ Microsoft.NET.Sdk.WebAssembly,,,2,,,,,,,,,,,,,,,,,,,,1,1
- Microsoft.NET.WebAssembly.Webcil,,,6,,,,,,,,,,,,,,,,,,,6,
+ Microsoft.NET.WebAssembly.Webcil,,,6,,,,,,,,,,,,,,,,,,,,6,
- Microsoft.VisualBasic,,,13,,,,,,,,,,,,,,,,,,,1,12
+ Microsoft.VisualBasic,,,13,,,,,,,,,,,,,,,,,,,,1,12
- Microsoft.WebAssembly.Build.Tasks,,,9,,,,,,,,,,,,,,,,,,,8,1
+ Microsoft.WebAssembly.Build.Tasks,,,9,,,,,,,,,,,,,,,,,,,,8,1
- Microsoft.Win32,,4,2,,,,,,,,,,,,,,,,,,4,,2
+ Microsoft.Win32,,4,2,,,,,,,,,,,,,,,,,,,4,,2
- Mono.Linker,,,293,,,,,,,,,,,,,,,,,,,145,148
+ Mono.Linker,,,293,,,,,,,,,,,,,,,,,,,,145,148
- MySql.Data.MySqlClient,48,,,,,,,,,,,,48,,,,,,,,,,
+ MySql.Data.MySqlClient,48,,,,,,,,,,,,48,,,,,,,,,,,
- Newtonsoft.Json,,,91,,,,,,,,,,,,,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,,,,,,,,,,,,,73,18
- ServiceStack,194,,7,27,,,,,75,,,,92,,,,,,,,,7,
+ ServiceStack,194,,7,27,,,,,75,,,,92,,,,,,,,,,7,
- SourceGenerators,,,5,,,,,,,,,,,,,,,,,,,,5
+ SourceGenerators,,,5,,,,,,,,,,,,,,,,,,,,,5
- System,54,47,10819,,6,5,5,,,4,1,,33,2,,6,15,17,4,3,,5512,5307
+ System,54,47,10819,,6,5,5,,,4,1,,33,,2,,6,15,17,4,3,,5512,5307
- Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,,,,,,,,
+ Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,,,,,,,,,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant