Java: Add support to ModuleImportDeclaration
#20097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IdrissRio
changed the title
ModuleImportDeclaration
IdrissRio
force-pushed
the
idrissrio/module-import-declarations
branch
3 times, most recently
from
16b0695 to
a16147c
Compare
IdrissRio
added
the
depends on internal PR
IdrissRio
force-pushed
the
idrissrio/module-import-declarations
branch
3 times, most recently
from
a24e4ae to
27cb373
Compare
IdrissRio
commented
Jul 30, 2025
| } | ||
| } | ||
|
|
||
| // Diagnostic Matches: Unknown location for jdk.internal.RequiresIdentity+Annotation No newline at end of file |
There was a problem hiding this comment.
This is an internally generated annotation without a specific source location.
Excluding it from diagnostic will be addressed in a separate PR.
IdrissRio
force-pushed
the
idrissrio/module-import-declarations
branch
from
27cb373 to
e4848e0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Java 25 module import declarations, implementing the new import module syntax feature. The implementation includes database schema updates, a new ModuleImportDeclaration class, and comprehensive test coverage.
Key changes:
- Database schema updated to handle the new module import kind (value 6 in imports table)
- Added
ModuleImportDeclarationclass extendingImportwith methods to access module information and imported types/packages - Upgrade/downgrade scripts for database compatibility
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| java/ql/lib/semmle/code/java/Import.qll | Adds ModuleImportDeclaration class with methods to get module info and imported types/packages |
| java/ql/lib/config/semmlecode.dbscheme | Updates imports table schema to include module import kind (6) with documentation |
| java/ql/lib/upgrades/.../semmlecode.dbscheme | New schema version adding MODULEIMPORT kind to imports documentation |
| java/ql/lib/upgrades/.../old.dbscheme | Previous schema version for upgrade compatibility |
| java/ql/lib/upgrades/.../upgrade.properties | Upgrade script properties for module import declarations |
| java/downgrades/.../semmlecode.dbscheme | Downgrade schema removing module import support |
| java/downgrades/.../upgrade.properties | Downgrade script properties |
| java/ql/test/library-tests/module-import-declarations/* | Test files validating module import functionality and expected outputs |
| java/ql/lib/change-notes/2025-07-21-module-import-declarations.md | Release note documenting the new feature |
IdrissRio
force-pushed
the
idrissrio/module-import-declarations
branch
3 times, most recently
from
e4848e0 to
3c0b807
Compare
jketema
reviewed
Aug 20, 2025
IdrissRio
force-pushed
the
idrissrio/module-import-declarations
branch
from
3c0b807 to
ccf5002
Compare
IdrissRio
force-pushed
the
idrissrio/java-upgrade-fix
branch
from
ba93ced to
564364b
Compare
IdrissRio
force-pushed
the
idrissrio/module-import-declarations
branch
2 times, most recently
from
0877afe to
75107ba
Compare
IdrissRio
force-pushed
the
idrissrio/java-upgrade-fix
branch
2 times, most recently
from
a34b362 to
5d2268f
Compare
IdrissRio
force-pushed
the
idrissrio/module-import-declarations
branch
from
75107ba to
8656461
Compare
jketema
reviewed
Sep 5, 2025
| * A module import declaration, which imports an entire module. | ||
| * | ||
| * For example, `import module java.base;` imports all packages exported | ||
| * by the `java.base module`, making their types available for use. |
There was a problem hiding this comment.
Was this maybe supposed to be:
Suggested change
| * by the `java.base module`, making their types available for use. | |
| * by the `java.base` module, making their types available for use. |
There was a problem hiding this comment.
The comment here mentions "types", but below I get a getAnImportedPackage. So what is actually being imported here?
There was a problem hiding this comment.
Good point. The declaration makes the exported packages available, and through them the types defined in those packages become accessible for use. I'll rephrase the comment.
IdrissRio
force-pushed
the
idrissrio/module-import-declarations
branch
2 times, most recently
from
27e7c17 to
6d8a014
Compare
owen-mc
reviewed
Sep 5, 2025
Comment on lines
184
to
187
| exists(Package pkg | | ||
| pkg = this.getAnImportedPackage() and | ||
| result.getPackage() = pkg | ||
| ) |
There was a problem hiding this comment.
This can be more concise and still understandable.
Suggested change
| exists(Package pkg | | |
| pkg = this.getAnImportedPackage() and | |
| result.getPackage() = pkg | |
| ) | |
| result.getPackage() = this.getAnImportedPackage() |
There was a problem hiding this comment.
Change applied, tested, and committed. Thanks 👍
IdrissRio
force-pushed
the
idrissrio/module-import-declarations
branch
from
0083d5a to
d5c5531
Compare
owen-mc
approved these changes
Sep 5, 2025
IdrissRio
force-pushed
the
idrissrio/module-import-declarations
branch
from
d5c5531 to
ed9ed43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Java 25 module import declarations:
ModuleImportDeclarationclassSee internal PR.