fix for UI form submission

Author: mattdholloway

pkg/github/issues.go

@@ -1101,15 +1101,12 @@ Options are:
 				return utils.NewToolResultError(err.Error()), nil, nil
 			}
 
-			// When insiders mode is enabled and this is an initial request (no title provided),
-			// show UI - the host will detect the UI metadata and display the form.
-			// If title is provided, this is a submission from the UI form, so proceed with the operation.
-			title, err := OptionalParam[string](args, "title")
-			if err != nil {
-				return utils.NewToolResultError(err.Error()), nil, nil
-			}
+			// When insiders mode is enabled, check if this is a UI form submission.
+			// The UI sends _ui_submitted=true to distinguish form submissions from LLM calls.
+			// Without this flag, always show the UI so the user can review/edit before submitting.
+			uiSubmitted, _ := OptionalParam[bool](args, "_ui_submitted")
 
-			if deps.GetFlags(ctx).InsidersMode && title == "" {
+			if deps.GetFlags(ctx).InsidersMode && !uiSubmitted {
 				if method == "update" {
 					issueNumber, numErr := RequiredInt(args, "issue_number")
 					if numErr != nil {
@@ -1120,6 +1117,11 @@ Options are:
 				return utils.NewToolResultText(fmt.Sprintf("Ready to create an issue in %s/%s. The interactive form will be displayed.", owner, repo)), nil, nil
 			}
 
+			title, err := OptionalParam[string](args, "title")
+			if err != nil {
+				return utils.NewToolResultError(err.Error()), nil, nil
+			}
+
 			// Optional parameters
 			body, err := OptionalParam[string](args, "body")
 			if err != nil {

pkg/github/pullrequests.go

@@ -555,17 +555,27 @@ func CreatePullRequest(t translations.TranslationHelperFunc) inventory.ServerToo
 				return utils.NewToolResultError(err.Error()), nil, nil
 			}
 
-			// Check if required params for PR creation are provided
-			title, _ := OptionalParam[string](args, "title")
-			head, _ := OptionalParam[string](args, "head")
-			base, _ := OptionalParam[string](args, "base")
+			// When insiders mode is enabled, check if this is a UI form submission.
+			// The UI sends _ui_submitted=true to distinguish form submissions from LLM calls.
+			uiSubmitted, _ := OptionalParam[bool](args, "_ui_submitted")
 
-			// When insiders mode is enabled and required params are missing, show UI
-			if deps.GetFlags(ctx).InsidersMode && (title == "" || head == "" || base == "") {
+			if deps.GetFlags(ctx).InsidersMode && !uiSubmitted {
 				return utils.NewToolResultText(fmt.Sprintf("Ready to create a pull request in %s/%s. The interactive form will be displayed.", owner, repo)), nil, nil
 			}
 
 			// When creating PR, title/head/base are required
+			title, err := OptionalParam[string](args, "title")
+			if err != nil {
+				return utils.NewToolResultError(err.Error()), nil, nil
+			}
+			head, err := OptionalParam[string](args, "head")
+			if err != nil {
+				return utils.NewToolResultError(err.Error()), nil, nil
+			}
+			base, err := OptionalParam[string](args, "base")
+			if err != nil {
+				return utils.NewToolResultError(err.Error()), nil, nil
+			}
 			if title == "" {
 				return utils.NewToolResultError("missing required parameter: title"), nil, nil
 			}

ui/src/apps/issue-write/App.tsx

@@ -621,7 +621,8 @@ function CreateIssueApp() {
         owner,
         repo,
         title: title.trim(),
-        body: body.trim()
+        body: body.trim(),
+        _ui_submitted: true
       };
 
       if (isUpdateMode && issueNumber) {

ui/src/apps/pr-write/App.tsx

@@ -290,7 +290,8 @@ function CreatePRApp() {
         head: headBranch,
         base: baseBranch,
         draft: isDraft,
-        maintainer_can_modify: maintainerCanModify
+        maintainer_can_modify: maintainerCanModify,
+        _ui_submitted: true
       });
 
       if (result.isError) {