remove show_ui param for now

Author: mattdholloway

internal/ghmcp/server.go

@@ -181,7 +181,6 @@ func NewMCPServer(cfg MCPServerConfig) (*mcp.Server, error) {
 		WithToolsets(enabledToolsets).
 		WithTools(cfg.EnabledTools).
 		WithFeatureChecker(featureChecker).
-		WithInsidersMode(cfg.InsidersMode).
 		WithServerInstructions()
 
 	// Apply token scope filtering if scopes are known (for PAT filtering)

pkg/github/__toolsnaps__/create_pull_request.snap

@@ -11,7 +11,7 @@
   "annotations": {
     "title": "Open new pull request"
   },
-  "description": "Create a new pull request in a GitHub repository.\n\nWhen show_ui is true, an interactive form is displayed for the user to fill in PR details. Use show_ui when:\n- Creating a new PR and you want user input on the details\n- The user hasn't specified all required fields (title, head, base, etc.)\n- Interactive feedback would be valuable (branch selection, reviewers, labels)\n\nWhen show_ui is false or omitted, the PR is created directly with the provided parameters.",
+  "description": "Create a new pull request in a GitHub repository.",
   "inputSchema": {
     "properties": {
       "base": {
@@ -42,10 +42,6 @@
         "description": "Repository name",
         "type": "string"
       },
-      "show_ui": {
-        "description": "If true, show an interactive form for the user to fill in PR details. If false or omitted, create the PR directly with the provided parameters.",
-        "type": "boolean"
-      },
       "title": {
         "description": "PR title",
         "type": "string"

pkg/github/__toolsnaps__/issue_write.snap

@@ -11,7 +11,7 @@
   "annotations": {
     "title": "Create or update issue."
   },
-  "description": "Create a new or update an existing issue in a GitHub repository.\n\nWhen show_ui is true, an interactive form is displayed for the user to fill in issue details. Use show_ui when:\n- Creating a new issue and you want user input on the details\n- The user hasn't specified all required fields (title, body, etc.)\n- Interactive feedback would be valuable\n\nWhen show_ui is false or omitted, the issue is created/updated directly with the provided parameters.",
+  "description": "Create a new or update an existing issue in a GitHub repository.",
   "inputSchema": {
     "properties": {
       "assignees": {
@@ -60,10 +60,6 @@
         "description": "Repository name",
         "type": "string"
       },
-      "show_ui": {
-        "description": "If true, show an interactive form for the user to fill in issue details. If false or omitted, create/update the issue directly with the provided parameters.",
-        "type": "boolean"
-      },
       "state": {
         "description": "New state",
         "enum": [

pkg/github/issues.go

@@ -1159,15 +1159,8 @@ func IssueWrite(t translations.TranslationHelperFunc) inventory.ServerTool {
 	return NewTool(
 		ToolsetMetadataIssues,
 		mcp.Tool{
-			Name: "issue_write",
-			Description: t("TOOL_ISSUE_WRITE_DESCRIPTION", `Create a new or update an existing issue in a GitHub repository.
-
-When show_ui is true, an interactive form is displayed for the user to fill in issue details. Use show_ui when:
-- Creating a new issue and you want user input on the details
-- The user hasn't specified all required fields (title, body, etc.)
-- Interactive feedback would be valuable
-
-When show_ui is false or omitted, the issue is created/updated directly with the provided parameters.`),
+			Name:        "issue_write",
+			Description: t("TOOL_ISSUE_WRITE_DESCRIPTION", "Create a new or update an existing issue in a GitHub repository."),
 			Annotations: &mcp.ToolAnnotations{
 				Title:        t("TOOL_ISSUE_WRITE_USER_TITLE", "Create or update issue."),
 				ReadOnlyHint: false,
@@ -1181,10 +1174,6 @@ When show_ui is false or omitted, the issue is created/updated directly with the
 			InputSchema: &jsonschema.Schema{
 				Type: "object",
 				Properties: map[string]*jsonschema.Schema{
-					"show_ui": {
-						Type:        "boolean",
-						Description: "If true, show an interactive form for the user to fill in issue details. If false or omitted, create/update the issue directly with the provided parameters.",
-					},
 					"method": {
 						Type: "string",
 						Description: `Write operation to perform on a single issue.
@@ -1270,15 +1259,8 @@ Options are:
 				return utils.NewToolResultError(err.Error()), nil, nil
 			}
 
-			// Check if UI mode is requested
-			showUI, err := OptionalParam[bool](args, "show_ui")
-			if err != nil {
-				return utils.NewToolResultError(err.Error()), nil, nil
-			}
-
-			// If show_ui is true and insiders mode is enabled, return a message indicating the UI should be shown
-			// The host will detect the UI metadata and display the form
-			if showUI && deps.GetFlags().InsidersMode {
+			// When insiders mode is enabled, show UI - the host will detect the UI metadata and display the form
+			if deps.GetFlags().InsidersMode {
 				if method == "update" {
 					issueNumber, numErr := RequiredInt(args, "issue_number")
 					if numErr != nil {

pkg/github/pullrequests.go

@@ -476,15 +476,8 @@ func CreatePullRequest(t translations.TranslationHelperFunc) inventory.ServerToo
 	return NewTool(
 		ToolsetMetadataPullRequests,
 		mcp.Tool{
-			Name: "create_pull_request",
-			Description: t("TOOL_CREATE_PULL_REQUEST_DESCRIPTION", `Create a new pull request in a GitHub repository.
-
-When show_ui is true, an interactive form is displayed for the user to fill in PR details. Use show_ui when:
-- Creating a new PR and you want user input on the details
-- The user hasn't specified all required fields (title, head, base, etc.)
-- Interactive feedback would be valuable (branch selection, reviewers, labels)
-
-When show_ui is false or omitted, the PR is created directly with the provided parameters.`),
+			Name:        "create_pull_request",
+			Description: t("TOOL_CREATE_PULL_REQUEST_DESCRIPTION", "Create a new pull request in a GitHub repository."),
 			Annotations: &mcp.ToolAnnotations{
 				Title:        t("TOOL_CREATE_PULL_REQUEST_USER_TITLE", "Open new pull request"),
 				ReadOnlyHint: false,
@@ -498,10 +491,6 @@ When show_ui is false or omitted, the PR is created directly with the provided p
 			InputSchema: &jsonschema.Schema{
 				Type: "object",
 				Properties: map[string]*jsonschema.Schema{
-					"show_ui": {
-						Type:        "boolean",
-						Description: "If true, show an interactive form for the user to fill in PR details. If false or omitted, create the PR directly with the provided parameters.",
-					},
 					"owner": {
 						Type:        "string",
 						Description: "Repository owner",
@@ -549,14 +538,8 @@ When show_ui is false or omitted, the PR is created directly with the provided p
 				return utils.NewToolResultError(err.Error()), nil, nil
 			}
 
-			// Check if UI mode is requested
-			showUI, err := OptionalParam[bool](args, "show_ui")
-			if err != nil {
-				return utils.NewToolResultError(err.Error()), nil, nil
-			}
-
-			// If show_ui is true and insiders mode is enabled, return a message indicating the UI should be shown
-			if showUI && deps.GetFlags().InsidersMode {
+			// When insiders mode is enabled, show UI - the host will detect the UI metadata and display the form
+			if deps.GetFlags().InsidersMode {
 				return utils.NewToolResultText(fmt.Sprintf("Ready to create a pull request in %s/%s. The interactive form will be displayed.", owner, repo)), nil, nil
 			}
 

pkg/github/pullrequests_test.go

@@ -2031,7 +2031,6 @@ func Test_CreatePullRequest(t *testing.T) {
 	assert.Equal(t, "create_pull_request", tool.Name)
 	assert.NotEmpty(t, tool.Description)
 	schema := tool.InputSchema.(*jsonschema.Schema)
-	assert.Contains(t, schema.Properties, "show_ui")
 	assert.Contains(t, schema.Properties, "owner")
 	assert.Contains(t, schema.Properties, "repo")
 	assert.Contains(t, schema.Properties, "title")

pkg/inventory/builder.go

@@ -5,8 +5,6 @@ import (
 	"fmt"
 	"sort"
 	"strings"
-
-	"github.com/google/jsonschema-go/jsonschema"
 )
 
 // ToolFilter is a function that determines if a tool should be included.
@@ -43,7 +41,6 @@ type Builder struct {
 	featureChecker       FeatureFlagChecker
 	filters              []ToolFilter // filters to apply to all tools
 	generateInstructions bool
-	insidersMode         bool
 }
 
 // NewBuilder creates a new Builder.
@@ -138,15 +135,6 @@ func (b *Builder) WithFilter(filter ToolFilter) *Builder {
 	return b
 }
 
-// WithInsidersMode enables or disables insiders mode features.
-// When insiders mode is disabled (default), UI-related parameters like "show_ui"
-// are removed from tool schemas to hide experimental features.
-// Returns self for chaining.
-func (b *Builder) WithInsidersMode(enabled bool) *Builder {
-	b.insidersMode = enabled
-	return b
-}
-
 // cleanTools trims whitespace and removes duplicates from tool names.
 // Empty strings after trimming are excluded.
 func cleanTools(tools []string) []string {
@@ -174,14 +162,8 @@ func cleanTools(tools []string) []string {
 // (i.e., they don't exist in the tool set and are not deprecated aliases).
 // This ensures invalid tool configurations fail fast at build time.
 func (b *Builder) Build() (*Inventory, error) {
-	// When insiders mode is disabled, strip show_ui parameters from tool schemas
-	tools := b.tools
-	if !b.insidersMode {
-		tools = stripInsidersParameters(b.tools)
-	}
-
 	r := &Inventory{
-		tools:             tools,
+		tools:             b.tools,
 		resourceTemplates: b.resourceTemplates,
 		prompts:           b.prompts,
 		deprecatedAliases: b.deprecatedAliases,
@@ -344,60 +326,3 @@ func (b *Builder) processToolsets() (map[ToolsetID]bool, []string, []ToolsetID,
 	}
 	return enabledToolsets, unrecognized, allToolsetIDs, validIDs, defaultToolsetIDList, descriptions
 }
-
-// stripInsidersParameters removes insiders-only parameters from tool schemas.
-// This creates shallow copies of tools that have insiders parameters to avoid
-// mutating the original tool definitions.
-func stripInsidersParameters(tools []ServerTool) []ServerTool {
-	result := make([]ServerTool, len(tools))
-	for i, tool := range tools {
-		if modified, ok := removeInsidersParameters(tool.Tool.InputSchema); ok {
-			// Make a shallow copy of the tool
-			toolCopy := tool
-			toolCopy.Tool.InputSchema = modified
-			result[i] = toolCopy
-		} else {
-			result[i] = tool
-		}
-	}
-	return result
-}
-
-// insidersParameters lists the parameter names that are insiders-only
-var insidersParameters = map[string]bool{
-	"show_ui": true,
-}
-
-// removeInsidersParameters removes insiders-only parameters from a schema.
-// Returns the modified schema and true if any changes were made.
-// Handles *jsonschema.Schema type used by most tools.
-func removeInsidersParameters(schema any) (any, bool) {
-	// Handle *jsonschema.Schema (the most common case)
-	if js, ok := schema.(*jsonschema.Schema); ok && js != nil {
-		if js.Properties == nil {
-			return schema, false
-		}
-		hasInsidersParam := false
-		for name := range js.Properties {
-			if insidersParameters[name] {
-				hasInsidersParam = true
-				break
-			}
-		}
-		if !hasInsidersParam {
-			return schema, false
-		}
-		// Create a new schema with insiders parameters removed
-		newProps := make(map[string]*jsonschema.Schema, len(js.Properties))
-		for name, prop := range js.Properties {
-			if !insidersParameters[name] {
-				newProps[name] = prop
-			}
-		}
-		newSchema := *js // shallow copy
-		newSchema.Properties = newProps
-		return &newSchema, true
-	}
-	// For other types (json.RawMessage, map[string]any, etc.), leave unchanged
-	return schema, false
-}

pkg/inventory/registry_test.go

@@ -6,7 +6,6 @@ import (
 	"fmt"
 	"testing"
 
-	"github.com/google/jsonschema-go/jsonschema"
 	"github.com/modelcontextprotocol/go-sdk/mcp"
 	"github.com/stretchr/testify/require"
 )
@@ -1833,51 +1832,3 @@ func TestWithTools_DeprecatedAliasAndFeatureFlag(t *testing.T) {
 		t.Errorf("Flag ON: Expected new_tool (via alias), got %s", availableOn[0].Tool.Name)
 	}
 }
-
-func TestWithInsidersMode(t *testing.T) {
-	// Create a tool with a jsonschema.Schema that has show_ui
-	toolWithShowUI := NewServerToolFromHandler(
-		mcp.Tool{
-			Name: "test_tool",
-			InputSchema: &jsonschema.Schema{
-				Type: "object",
-				Properties: map[string]*jsonschema.Schema{
-					"show_ui": {
-						Type:        "boolean",
-						Description: "Show UI",
-					},
-					"owner": {
-						Type:        "string",
-						Description: "Owner",
-					},
-				},
-			},
-		},
-		testToolsetMetadata("test"),
-		func(_ any) mcp.ToolHandler {
-			return func(_ context.Context, _ *mcp.CallToolRequest) (*mcp.CallToolResult, error) {
-				return nil, nil
-			}
-		},
-	)
-
-	tools := []ServerTool{toolWithShowUI}
-
-	// Test with insiders mode disabled - show_ui should be stripped
-	regNoInsiders := mustBuild(t, NewBuilder().SetTools(tools).WithInsidersMode(false))
-	toolsNoInsiders := regNoInsiders.AllTools()
-	require.Len(t, toolsNoInsiders, 1)
-	schema, ok := toolsNoInsiders[0].Tool.InputSchema.(*jsonschema.Schema)
-	require.True(t, ok, "Schema should be *jsonschema.Schema")
-	require.Nil(t, schema.Properties["show_ui"], "show_ui should be stripped when insiders mode is disabled")
-	require.NotNil(t, schema.Properties["owner"], "owner should still exist")
-
-	// Test with insiders mode enabled - show_ui should remain
-	regWithInsiders := mustBuild(t, NewBuilder().SetTools(tools).WithInsidersMode(true))
-	toolsWithInsiders := regWithInsiders.AllTools()
-	require.Len(t, toolsWithInsiders, 1)
-	schemaInsiders, ok := toolsWithInsiders[0].Tool.InputSchema.(*jsonschema.Schema)
-	require.True(t, ok, "Schema should be *jsonschema.Schema")
-	require.NotNil(t, schemaInsiders.Properties["show_ui"], "show_ui should remain when insiders mode is enabled")
-	require.NotNil(t, schemaInsiders.Properties["owner"], "owner should still exist")
-}