Skip to content

Commit 202355e

Browse files
committed
Added testing of more variations of date formats (#327).
1 parent 82c1dee commit 202355e

File tree

1 file changed

+41
-3
lines changed

1 file changed

+41
-3
lines changed

src/test/java/org/gitlab4j/api/TestISO8601.java

Lines changed: 41 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,51 @@
1010

1111
public class TestISO8601 {
1212

13-
private static final String SPACEY_GITLAB_DATE = "2018-03-12 10:16:46 +0800";
14-
private static final String ISO8601_GITLAB_DATE ="2018-03-12T10:16:46+0800";
13+
private static final String SPACEY_GITLAB_DATE = "2018-03-12 10:16:46 +0700";
14+
private static final String ISO8601_GITLAB_DATE ="2018-03-12T10:16:46+0700";
15+
16+
private static final String DATE_ONLY = "2018-03-12";
17+
private static final String DATE_AT_MIDNIGHT ="2018-03-12T00:00:00Z";
18+
19+
private static final String SPACEY_GITLAB_DATE_WITH_MSEC = "2018-03-12 10:16:46.123 +0700";
20+
private static final String ISO8601_GITLAB_DATE_WITH_MSEC ="2018-03-12T10:16:46.123+0700";
21+
22+
private static final String ISO8601_DATE_MSEC = "2018-03-12T10:16:46.123Z";
23+
private static final String ISO8601_DATE_OFFSET_COLON = "2018-03-12T10:16:46.123+00:00";
24+
private static final String ISO8601_GITLAB_DATE_MSEC = "2018-03-12T03:16:46.123-0700";
1525

1626
@Test
1727
public void testGitlabDateParse() throws ParseException {
1828
Date spaceyDate = ISO8601.toDate(SPACEY_GITLAB_DATE);
1929
Date gitlabDate = ISO8601.toDate(ISO8601_GITLAB_DATE);
20-
assertEquals(spaceyDate, gitlabDate);
30+
assertEquals(spaceyDate, gitlabDate);
31+
}
32+
33+
@Test
34+
public void testDateOnlyParse() throws ParseException {
35+
Date dateOnly = ISO8601.toDate(DATE_ONLY);
36+
Date dateAtMidnight = ISO8601.toDate(DATE_AT_MIDNIGHT);
37+
assertEquals(dateOnly, dateAtMidnight);
38+
}
39+
40+
@Test
41+
public void testGitlabMsecDateParse() throws ParseException {
42+
Date spaceyDate = ISO8601.toDate(SPACEY_GITLAB_DATE_WITH_MSEC);
43+
Date gitlabDate = ISO8601.toDate(ISO8601_GITLAB_DATE_WITH_MSEC);
44+
assertEquals(spaceyDate, gitlabDate);
45+
}
46+
47+
@Test
48+
public void testMsecDateParse() throws ParseException {
49+
Date msecDate = ISO8601.toDate(ISO8601_DATE_MSEC);
50+
Date gitlabMsecDate = ISO8601.toDate(ISO8601_GITLAB_DATE_MSEC);
51+
assertEquals(msecDate, gitlabMsecDate);
52+
}
53+
54+
@Test
55+
public void testOffsetColonDateParse() throws ParseException {
56+
Date msecDate = ISO8601.toDate(ISO8601_DATE_MSEC);
57+
Date gitlabMsecDate = ISO8601.toDate(ISO8601_DATE_OFFSET_COLON);
58+
assertEquals(msecDate, gitlabMsecDate);
2159
}
2260
}

0 commit comments

Comments
 (0)