Merge pull request #2 from k0ral/identity2

fix: Empty name and/or email are valid use cases.

Author: zricethezav

gitdiff/patch_header.go

@@ -82,9 +82,9 @@ func (i PatchIdentity) String() string {
 }
 
 // ParsePatchIdentity parses a patch identity string. A valid string contains a
-// non-empty name followed by an email address in angle brackets. Like Git,
+// name followed by an email address in angle brackets.
 // ParsePatchIdentity does not require that the email address is valid or
-// properly formatted, only that it is non-empty. The name must not contain a
+// properly formatted. The name must not contain a
 // left angle bracket, '<', and the email address must not contain a right
 // angle bracket, '>'.
 func ParsePatchIdentity(s string) (PatchIdentity, error) {
@@ -109,9 +109,6 @@ func ParsePatchIdentity(s string) (PatchIdentity, error) {
 	if emailStart > 0 && emailEnd > 0 {
 		email = strings.TrimSpace(s[emailStart:emailEnd])
 	}
-	if name == "" || email == "" {
-		return PatchIdentity{}, fmt.Errorf("invalid identity string: %s", s)
-	}
 
 	return PatchIdentity{Name: name, Email: email}, nil
 }

gitdiff/patch_header_test.go

@@ -34,11 +34,38 @@ func TestParsePatchIdentity(t *testing.T) {
 		},
 		"missingName": {
 			Input: "<[email protected]>",
-			Err:   "invalid identity",
+			Output: PatchIdentity{
+				Name:  "",
+				Email: "[email protected]",
+			},
 		},
 		"missingEmail": {
 			Input: "Morton Haypenny",
-			Err:   "invalid identity",
+			Output: PatchIdentity{
+				Name:  "",
+				Email: "",
+			},
+		},
+		"emptyEmail": {
+			Input: "Morton Haypenny <>",
+			Output: PatchIdentity{
+				Name:  "Morton Haypenny",
+				Email: "",
+			},
+		},
+		"missingNameAndEmail": {
+			Input: "",
+			Output: PatchIdentity{
+				Name:  "",
+				Email: "",
+			},
+		},
+		"emptyNameAndEmail": {
+			Input: " <>",
+			Output: PatchIdentity{
+				Name:  "",
+				Email: "",
+			},
 		},
 		"unclosedEmail": {
 			Input: "Morton Haypenny <[email protected]",