Skip to content

Commit e55c822

Browse files
authored
Merge pull request microsoft#187302 from microsoft/aamunger/dirtyNotebooks
treat 'soon to be auto-saved' as saving
2 parents 020b2d5 + 54064e1 commit e55c822

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/vs/workbench/contrib/notebook/common/notebookEditorInput.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import { VSBuffer } from 'vs/base/common/buffer';
2424
import { IWorkingCopyIdentifier } from 'vs/workbench/services/workingCopy/common/workingCopy';
2525
import { NotebookProviderInfo } from 'vs/workbench/contrib/notebook/common/notebookProvider';
2626
import { NotebookPerfMarks } from 'vs/workbench/contrib/notebook/common/notebookPerformance';
27-
import { IFilesConfigurationService } from 'vs/workbench/services/filesConfiguration/common/filesConfigurationService';
27+
import { AutoSaveMode, IFilesConfigurationService } from 'vs/workbench/services/filesConfiguration/common/filesConfigurationService';
2828
import { IExtensionService } from 'vs/workbench/services/extensions/common/extensions';
2929
import { localize } from 'vs/nls';
3030
import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
@@ -216,6 +216,14 @@ export class NotebookEditorInput extends AbstractResourceEditorInput {
216216
return await this._editorModelReference.object.saveAs(target);
217217
}
218218

219+
override isSaving(): boolean {
220+
if (this.isDirty() && !this.hasCapability(EditorInputCapabilities.Untitled) && this.filesConfigurationService.getAutoSaveMode() === AutoSaveMode.AFTER_SHORT_DELAY) {
221+
return true; // will be saved soon
222+
}
223+
224+
return super.isSaving();
225+
}
226+
219227
private async _suggestName(provider: NotebookProviderInfo, suggestedFilename: string) {
220228
// guess file extensions
221229
const firstSelector = provider.selectors[0];

0 commit comments

Comments
 (0)