Skip to content

Commit 83bd536

Browse files
authored
chore(ci): bump actions/cache (#1157)
* chore(ci): bump actions/cache * chore: drop valgrind-based benchmarking The valgrind output seems to have changed (`KeyError: 'DLmr'`). Dropping the feature because I couldn't find a fix. * chore(ci): drop node 18, add node 24
1 parent c702357 commit 83bd536

File tree

3 files changed

+1
-179
lines changed

3 files changed

+1
-179
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
strategy:
1010
matrix:
1111
os: [ubuntu-latest]
12-
node-version: [18.x, 20.x, 22.x]
12+
node-version: [20.x, 22.x, 24.x]
1313

1414
steps:
1515
- uses: actions/checkout@v2
@@ -29,26 +29,3 @@ jobs:
2929
yarn build-types
3030
[ $(git diff types.d.ts | wc -l) -gt 0 ] && echo 'Diff exists in types.d.ts. Please change jsdoc.' && exit 1
3131
tsc --noEmit types.d.ts
32-
33-
- name: install valgrind
34-
run: sudo apt-get install -y valgrind
35-
36-
- name: benchmark
37-
run: python cachegrind.py node test/benchmark2.js > output.txt
38-
39-
- name: Download previous benchmark result
40-
uses: actions/cache@v1
41-
with:
42-
path: ./cache
43-
key: ${{ runner.os }}-${{matrix.node-version}}-benchmark
44-
45-
- name: Store benchmark result
46-
uses: benchmark-action/github-action-benchmark@v1
47-
with:
48-
tool: "customSmallerIsBetter"
49-
output-file-path: output.txt
50-
external-data-json-path: ./cache/benchmark-data.json
51-
alert-threshold: "105%"
52-
fail-on-alert: true
53-
env:
54-
CI: true

cachegrind.py

Lines changed: 0 additions & 137 deletions
This file was deleted.

test/benchmark2.js

Lines changed: 0 additions & 18 deletions
This file was deleted.

0 commit comments

Comments
 (0)