fix js codegen allowing underscore after decimal

Author: ptdewey

compiler-core/src/javascript/expression.rs

@@ -288,7 +288,7 @@ impl<'module, 'a> Generator<'module, 'a> {
             TypedExpr::String { value, .. } => string(value),
 
             TypedExpr::Int { value, .. } => int(value),
-            TypedExpr::Float { value, .. } => float(value),
+            TypedExpr::Float { float_value, .. } => float_value.value().to_doc(),
 
             TypedExpr::List { elements, tail, .. } => {
                 self.not_in_tail_position(Some(Ordering::Strict), |this| match tail {

compiler-core/src/javascript/tests/numbers.rs

@@ -431,6 +431,31 @@ pub fn main() {
     );
 }
 
+#[test]
+fn underscore_after_decimal_point() {
+    assert_js!(
+        "
+pub fn main() {
+  0._1
+}
+"
+    );
+}
+
+#[test]
+fn underscore_after_decimal_point_case_statement() {
+    assert_js!(
+        "
+pub fn main(x) {
+  case x {
+    0._1 -> \"bar\"
+    _ -> \"foo\"
+  }
+}
+"
+    );
+}
+
 #[test]
 fn division_by_zero_float() {
     assert_js!(

compiler-core/src/javascript/tests/snapshots/gleam_core__javascript__tests__numbers__float_literals.snap

@@ -1,8 +1,6 @@
 ---
 source: compiler-core/src/javascript/tests/numbers.rs
-assertion_line: 23
 expression: "\npub fn go() {\n  1.5\n  2.0\n  -0.1\n  1.\n}\n"
-snapshot_kind: text
 ---
 ----- SOURCE CODE
 
@@ -19,5 +17,5 @@ export function go() {
   1.5;
   2.0;
   -0.1;
-  return 1.;
+  return 1.0;
 }

compiler-core/src/javascript/tests/snapshots/gleam_core__javascript__tests__numbers__float_scientific_literals.snap

@@ -1,8 +1,6 @@
 ---
 source: compiler-core/src/javascript/tests/numbers.rs
-assertion_line: 37
 expression: "\npub fn go() {\n  0.01e-1\n  0.01e-0\n  -10.01e-1\n  -10.01e-0\n  100.001e523\n  -100.001e-523\n  100.001e123_456_789\n  -100.001e-123_456_789\n}\n"
-snapshot_kind: text
 ---
 ----- SOURCE CODE
 
@@ -20,12 +18,12 @@ pub fn go() {
 
 ----- COMPILED JAVASCRIPT
 export function go() {
-  0.01e-1;
-  0.01e-0;
-  -10.01e-1;
-  -10.01e-0;
-  100.001e523;
-  -100.001e-523;
-  100.001e123_456_789;
-  return -100.001e-123_456_789;
+  0.001;
+  0.01;
+  -1.001;
+  -10.01;
+  inf;
+  -0.0;
+  inf;
+  return -0.0;
 }

compiler-core/src/javascript/tests/snapshots/gleam_core__javascript__tests__numbers__preceeding_zeros_float.snap

@@ -1,8 +1,6 @@
 ---
 source: compiler-core/src/javascript/tests/numbers.rs
-assertion_line: 264
 expression: "\npub fn main() {\n  09_179.1\n}\n"
-snapshot_kind: text
 ---
 ----- SOURCE CODE
 
@@ -13,5 +11,5 @@ pub fn main() {
 
 ----- COMPILED JAVASCRIPT
 export function main() {
-  return 9_179.1;
+  return 9179.1;
 }

compiler-core/src/javascript/tests/snapshots/gleam_core__javascript__tests__numbers__underscore_after_decimal_point.snap

@@ -0,0 +1,15 @@
+---
+source: compiler-core/src/javascript/tests/numbers.rs
+expression: "\npub fn main() {\n  0._1\n}\n"
+---
+----- SOURCE CODE
+
+pub fn main() {
+  0._1
+}
+
+
+----- COMPILED JAVASCRIPT
+export function main() {
+  return 0.1;
+}

compiler-core/src/javascript/tests/snapshots/gleam_core__javascript__tests__numbers__underscore_after_decimal_point_case_statement.snap

@@ -0,0 +1,22 @@
+---
+source: compiler-core/src/javascript/tests/numbers.rs
+expression: "\npub fn main(x) {\n  case x {\n    0._1 -> \"bar\"\n    _ -> \"foo\"\n  }\n}\n"
+---
+----- SOURCE CODE
+
+pub fn main(x) {
+  case x {
+    0._1 -> "bar"
+    _ -> "foo"
+  }
+}
+
+
+----- COMPILED JAVASCRIPT
+export function main(x) {
+  if (x === 0.1) {
+    return "bar";
+  } else {
+    return "foo";
+  }
+}

compiler-core/src/javascript/tests/snapshots/gleam_core__javascript__tests__numbers__wide_float_div.snap

@@ -11,5 +11,5 @@ pub fn go() {
 
 ----- COMPILED JAVASCRIPT
 export function go() {
-  return 111111111111111111111111111111. / 22222222222222222222222222222222222.;
+  return 1.111111111111111e29 / 2.222222222222222e34;
 }