fix tests

Author: cedric-anne

phpunit/functional/Glpi/Asset/CustomFieldDefinitionTest.php

@@ -661,7 +661,7 @@ public function testSearchDropdownField(): void
             'custom_customtagsingle' => getItemByTypeName('Glpi\\CustomDropdown\\CustomTagDropdown', 'Tag01', true),
             'custom_customtagmulti' => [
                 getItemByTypeName('Glpi\\CustomDropdown\\CustomTagDropdown', 'Tag01', true),
-                getItemByTypeName('Glpi\\CustomDropdown\\CustomTagDropdown', 'Tag02', true)
+                getItemByTypeName('Glpi\\CustomDropdown\\CustomTagDropdown', 'Tag02', true),
             ],
         ], ['custom_customtagsingle', 'custom_customtagmulti']);
 
@@ -684,8 +684,8 @@ public function testSearchDropdownField(): void
                     'field' => $multiple_dropdown_opt,
                     'searchtype' => 'contains',
                     'value' => 'Tag',
-                ]
-            ]
+                ],
+            ],
         ], [$single_dropdown_opt, $multiple_dropdown_opt]);
 
         $this->assertCount(1, $data['data']['rows']);

src/Glpi/Asset/CustomFieldType/DropdownType.php

@@ -155,7 +155,7 @@ public function getSearchOption(): ?array
             $opt['joinparams']['condition'] = [
                 QueryFunction::jsonContains([
                     'REFTABLE.custom_fields',
-                    'NEWTABLE.id',
+                    QueryFunction::cast('NEWTABLE.id', 'JSON'),
                     new QueryExpression($DB::quoteValue('$."' . $this->custom_field->fields['id'] . '"')),
                 ]),
             ];

tests/src/autoload/functions.php

@@ -792,7 +792,7 @@ function loadDataset()
                 'name' => 'TestA',
                 'entities_id' => '_test_root_entity',
                 'custom_teststring' => 'Test String A',
-                'custom_customtagsingle' => "1"
+                'custom_customtagsingle' => "1",
             ],
             [
                 'name' => 'TestB',