Update status readyness check

Author: zivkovicmilos

client/client.go

@@ -23,7 +23,6 @@ type Client interface {
 	// and wait for it to be committed to the chain
 	SendTransactionCommit(tx *std.Tx) (*coreTypes.ResultBroadcastTxCommit, error)
 
-	// Ping calls the simplest element on the implementation that is able
-	// to tell if it is still alive. If there is any problem, it returns an error.
-	Ping() error
+	// Status fetches the node's latest status
+	Status() (*coreTypes.ResultStatus, error)
 }

client/http/http.go

@@ -63,8 +63,6 @@ func (c *Client) SendTransactionCommit(tx *std.Tx) (*coreTypes.ResultBroadcastTx
 	return c.client.BroadcastTxCommit(context.Background(), aminoTx)
 }
 
-func (c *Client) Ping() error {
-	_, err := c.client.Health(context.Background())
-
-	return err
+func (c *Client) Status() (*coreTypes.ResultStatus, error) {
+	return c.client.Status(context.Background(), nil)
 }

handler.go

@@ -223,7 +223,8 @@ func (f *Faucet) healthcheckHandler(_ http.ResponseWriter, r *http.Request) {
 
 // readycheckHandler is the default ready check handler for the faucet
 func (f *Faucet) readycheckHandler(w http.ResponseWriter, r *http.Request) {
-	err := f.client.Ping()
+	// Grab the node's status
+	status, err := f.client.Status()
 	if err != nil {
 		render.JSON(w, r, &response{
 			Message: fmt.Sprintf("node not ready: %s", err.Error()),
@@ -240,7 +241,8 @@ func (f *Faucet) readycheckHandler(w http.ResponseWriter, r *http.Request) {
 	render.JSON(w, r, &response{
 		Message: "node is ready",
 		Info: map[string]any{
-			"time": time.Now().String(),
+			"height": status.SyncInfo.LatestBlockHeight,
+			"time":   time.Now().String(),
 		},
 	})
 }

mock_test.go

@@ -137,14 +137,14 @@ type (
 	getAccountDelegate            func(crypto.Address) (std.Account, error)
 	sendTransactionSyncDelegate   func(tx *std.Tx) (*coreTypes.ResultBroadcastTx, error)
 	sendTransactionCommitDelegate func(tx *std.Tx) (*coreTypes.ResultBroadcastTxCommit, error)
-	pingDelegate                  func() error
+	statusDelegate                func() (*coreTypes.ResultStatus, error)
 )
 
 type mockClient struct {
 	getAccountFn            getAccountDelegate
 	sendTransactionSyncFn   sendTransactionSyncDelegate
 	sendTransactionCommitFn sendTransactionCommitDelegate
-	pingFn                  pingDelegate
+	statusFn                statusDelegate
 }
 
 func (m *mockClient) GetAccount(address crypto.Address) (std.Account, error) {
@@ -171,12 +171,12 @@ func (m *mockClient) SendTransactionCommit(tx *std.Tx) (*coreTypes.ResultBroadca
 	return nil, nil
 }
 
-func (m *mockClient) Ping() error {
-	if m.pingFn != nil {
-		return m.pingFn()
+func (m *mockClient) Status() (*coreTypes.ResultStatus, error) {
+	if m.statusFn != nil {
+		return m.statusFn()
 	}
 
-	return nil
+	return nil, nil
 }
 
 type (