Gotype should check an entire package instead of one file.

[DmitriyMV]

Continuation of #1967

Right now, if your project has more than one file and type, plugin will produce errors. That's because currently gotype is only checking selected file without getting types from others, so it doesn't know anything about them. Solution is quite simple - just check the folder and not the file.

In case of /src/github.com/username/goproject/main.go should become /src/github.com/username/goproject

[dlsniper]

That's actually incorrect in my case. I've tested the integration just now and in my example this won't work.

I've checked a file that's in a deeper package structure and I get an error about missing imports (even if the files, packages, are on disk). I've tried using a directory instead of a file and I've got the same issue.

At the moment I don't have a proper solution for this to work but as soon as I have one I'll add it here.

[dlsniper]

Ok so I've found the root of the issue.
According to golang/go#10969 which points to golang/go#10249 (comment) this happens because go install isn't used on the package at least once before applying gotype. I'll try to submit a fix for this soonish.

[zolotov]

Solution is quite simple - just check the folder and not the file.

So select the folder and run gotype action, what's the problem?

[dlsniper]

So select the folder and run gotype action, what's the problem?

When using import statements for other packages that won't work, see my comment.

[zolotov]

The original issue is about running on directory.

As for go install and other stuff. Since gotype is not really smart, I prefer do not fix it and wait until we'll get our own type checking system.

[dlsniper]

The original issue is about running on directory.

Nope, I believe that the author of the issue didn't had the full understanding of the issue that's why it was suggested to run gotype on a folder.

I prefer do not fix it and wait until we'll get our own type checking system.

Sure but the feature is already there so then maybe it should be removed as it doesn't work in most of the use-cases (I rarely work on packages that don't import other packages so for me this is broken almost always.

[DmitriyMV]

No - gotype just requires that imported packages should have object files (the ones in /pkg dir). Anyway, I think that the issue can be closed, because @zolotov answer (choosing directory instead of file) is working.

Gotype can be removed, but then I would really like the more general solution of "error line highliter" for the third party tools.

[dlsniper]

No - gotype just requires that imported packages should have object files (the ones in /pkg dir).

Which in my case doesn't happen as I rarely (almost never) use go install on a package. Also, if we move more and more functionality to the IDE (which we want in the first place), there are less chances for packages to be "installed" thus the need to have go install.

[DmitriyMV]

But you are using go get functionality to install 3rd party libraries. gotype is 3rd party analyzing tool, so it contains some requirements for its correct usage. Of course I already mentioned that with so many 3rd party tools in Go ecosystem, a more general approach to this problem would be better.

[dlsniper]

I meant on packages that I newly create, I'm using go get to fetch even non-go repos nowadays but I almost never use go get on my own packages... Also as the IDE runs projects with go build or go run it further shows either the need to run go install when executing tools such as these or a different approach to running apps (run go install first there?).

gotype is 3rd party analyzing tool

No, it's meant to be used with any go package, not just 3rd party.