lint: add prettier config and format all files

Author: andreynering

.prettierignore

@@ -1 +1 @@
-**/*.js
+/bin

prettier.config.js

@@ -0,0 +1,4 @@
+module.exports = {
+  trailingComma: 'none',
+  singleQuote: true
+};

src/actions/install.js

@@ -7,13 +7,12 @@ const verifyAndPlaceBinary = require('../assets/binary');
  * Select a resource handling strategy based on given options.
  */
 function getStrategy({ url }) {
-
   if (url.endsWith('.tar.gz')) {
-      return require('../assets/untar');
+    return require('../assets/untar');
   } else if (url.endsWith('.zip')) {
-      return require('../assets/unzip');
+    return require('../assets/unzip');
   } else {
-      return require('../assets/move');
+    return require('../assets/move');
   }
 }
 
@@ -26,7 +25,6 @@ function getStrategy({ url }) {
  *  See: https://docs.npmjs.com/files/package.json#bin
  */
 function install(callback) {
-
   const opts = parsePackageJson();
   if (!opts) return callback('Invalid inputs');
 
@@ -38,16 +36,20 @@ function install(callback) {
 
   req.on('error', () => callback('Error downloading from URL: ' + opts.url));
   req.on('response', (res) => {
-      if (res.statusCode !== 200) return callback('Error downloading binary. HTTP Status Code: ' + res.statusCode);
-
-      const strategy = getStrategy(opts);
-
-      strategy({
-          opts,
-          req,
-          onSuccess: () => verifyAndPlaceBinary(opts.binName, opts.binPath, callback),
-          onError: callback
-      });
+    if (res.statusCode !== 200)
+      return callback(
+        'Error downloading binary. HTTP Status Code: ' + res.statusCode
+      );
+
+    const strategy = getStrategy(opts);
+
+    strategy({
+      opts,
+      req,
+      onSuccess: () =>
+        verifyAndPlaceBinary(opts.binName, opts.binPath, callback),
+      onError: callback
+    });
   });
 }
 

src/actions/install.spec.js

@@ -17,17 +17,15 @@ jest.mock('../../src/assets/unzip');
 jest.mock('../../src/assets/binary');
 
 describe('install()', () => {
-
   let callback, requestEvents;
 
   beforeEach(() => {
-
     callback = jest.fn();
 
     requestEvents = new EventEmitter();
   });
 
-  it('should call callback with error if package.json did not return value' , () => {
+  it('should call callback with error if package.json did not return value', () => {
     common.parsePackageJson.mockReturnValueOnce(undefined);
 
     install(callback);
@@ -43,7 +41,9 @@ describe('install()', () => {
 
     requestEvents.emit('error');
 
-    expect(callback).toHaveBeenCalledWith('Error downloading from URL: http://url');
+    expect(callback).toHaveBeenCalledWith(
+      'Error downloading from URL: http://url'
+    );
   });
 
   it('should call callback with error on response with status code different than 200', () => {
@@ -54,7 +54,9 @@ describe('install()', () => {
 
     requestEvents.emit('response', { statusCode: 404 });
 
-    expect(callback).toHaveBeenCalledWith('Error downloading binary. HTTP Status Code: 404');
+    expect(callback).toHaveBeenCalledWith(
+      'Error downloading binary. HTTP Status Code: 404'
+    );
   });
 
   it('should pick move strategy if url is an uncompressed binary', () => {
@@ -92,13 +94,21 @@ describe('install()', () => {
 
   it('should call verifyAndPlaceCallback on success', () => {
     request.mockReturnValueOnce(requestEvents);
-    common.parsePackageJson.mockReturnValueOnce({ url: 'http://url', binName: 'command', binPath: './bin' });
+    common.parsePackageJson.mockReturnValueOnce({
+      url: 'http://url',
+      binName: 'command',
+      binPath: './bin'
+    });
     move.mockImplementationOnce(({ onSuccess }) => onSuccess());
 
     install(callback);
 
     requestEvents.emit('response', { statusCode: 200 });
 
-    expect(verifyAndPlaceCallback).toHaveBeenCalledWith('command', './bin', callback);
+    expect(verifyAndPlaceCallback).toHaveBeenCalledWith(
+      'command',
+      './bin',
+      callback
+    );
   });
 });

src/actions/uninstall.js

@@ -3,21 +3,20 @@ const { unlinkSync } = require('fs');
 const { parsePackageJson, getInstallationPath } = require('../common');
 
 function uninstall(callback) {
-
   const { binName } = parsePackageJson();
 
   getInstallationPath((err, installationPath) => {
-      if (err) {
-          return callback(err);
-      }
+    if (err) {
+      return callback(err);
+    }
 
-      try {
-          unlinkSync(join(installationPath, binName));
-      } catch(ex) {
-          // Ignore errors when deleting the file.
-      }
+    try {
+      unlinkSync(join(installationPath, binName));
+    } catch (ex) {
+      // Ignore errors when deleting the file.
+    }
 
-      return callback(null);
+    return callback(null);
   });
 }
 

src/actions/uninstall.spec.js

@@ -7,11 +7,9 @@ jest.mock('fs');
 jest.mock('../../src/common');
 
 describe('uninstall()', () => {
-
   let callback;
 
   beforeEach(() => {
-
     callback = jest.fn();
 
     common.parsePackageJson.mockReturnValueOnce({ binName: 'command' });
@@ -28,26 +26,29 @@ describe('uninstall()', () => {
   });
 
   it('should call unlinkSync with binary and installation path', () => {
-
-    common.getInstallationPath.mockImplementationOnce((cb) => cb(null, './bin'));
+    common.getInstallationPath.mockImplementationOnce((cb) =>
+      cb(null, './bin')
+    );
 
     uninstall(callback);
 
     expect(fs.unlinkSync).toHaveBeenCalledWith(path.join('bin', 'command'));
   });
 
   it('should call callback on success', () => {
-
-    common.getInstallationPath.mockImplementationOnce((cb) => cb(null, './bin'));
+    common.getInstallationPath.mockImplementationOnce((cb) =>
+      cb(null, './bin')
+    );
 
     uninstall(callback);
 
     expect(callback).toHaveBeenCalledWith(null);
   });
 
   it('should call callback regardless of errors on unlink', () => {
-
-    common.getInstallationPath.mockImplementationOnce((cb) => cb(null, './bin'));
+    common.getInstallationPath.mockImplementationOnce((cb) =>
+      cb(null, './bin')
+    );
 
     fs.unlinkSync.mockImplementationOnce(() => {
       throw new Error();

src/assets/binary.js

@@ -4,22 +4,24 @@ const { getInstallationPath } = require('../common');
 
 function verifyAndPlaceBinary(binName, binPath, callback) {
   if (!existsSync(join(binPath, binName))) {
-    return callback(`Downloaded binary does not contain the binary specified in configuration - ${binName}`);
+    return callback(
+      `Downloaded binary does not contain the binary specified in configuration - ${binName}`
+    );
   }
 
   getInstallationPath((err, installationPath) => {
-      if (err) {
-        return callback(err);
-      }
+    if (err) {
+      return callback(err);
+    }
 
-      // Move the binary file and make sure it is executable
-      copyFileSync(join(binPath, binName), join(installationPath, binName));
-      unlinkSync(join(binPath, binName));
-      chmodSync(join(installationPath, binName), '755');
+    // Move the binary file and make sure it is executable
+    copyFileSync(join(binPath, binName), join(installationPath, binName));
+    unlinkSync(join(binPath, binName));
+    chmodSync(join(installationPath, binName), '755');
 
-      console.log('Placed binary on', join(installationPath, binName));
+    console.log('Placed binary on', join(installationPath, binName));
 
-      callback(null);
+    callback(null);
   });
 }
 

src/assets/binary.spec.js

@@ -18,7 +18,9 @@ describe('verifyAndPlaceBinary()', () => {
 
     verifyAndPlaceBinary('command', './bin', callback);
 
-    expect(callback).toHaveBeenCalledWith('Downloaded binary does not contain the binary specified in configuration - command');
+    expect(callback).toHaveBeenCalledWith(
+      'Downloaded binary does not contain the binary specified in configuration - command'
+    );
   });
 
   it('should call callback with error if installation path cannot be found', () => {
@@ -34,7 +36,9 @@ describe('verifyAndPlaceBinary()', () => {
 
   it('should call callback with null on success', () => {
     fs.existsSync.mockReturnValueOnce(true);
-    common.getInstallationPath.mockImplementationOnce((cb) => cb(null, path.sep + path.join('usr', 'local', 'bin')));
+    common.getInstallationPath.mockImplementationOnce((cb) =>
+      cb(null, path.sep + path.join('usr', 'local', 'bin'))
+    );
 
     verifyAndPlaceBinary('command', './bin', callback);
 
@@ -43,10 +47,15 @@ describe('verifyAndPlaceBinary()', () => {
 
   it('should move the binary to installation directory', () => {
     fs.existsSync.mockReturnValueOnce(true);
-    common.getInstallationPath.mockImplementationOnce((cb) => cb(null, path.sep + path.join('usr', 'local', 'bin')));
+    common.getInstallationPath.mockImplementationOnce((cb) =>
+      cb(null, path.sep + path.join('usr', 'local', 'bin'))
+    );
 
     verifyAndPlaceBinary('command', './bin', callback);
 
-    expect(fs.copyFileSync).toHaveBeenCalledWith(path.join('bin', 'command'), path.sep + path.join('usr', 'local', 'bin', 'command'));
+    expect(fs.copyFileSync).toHaveBeenCalledWith(
+      path.join('bin', 'command'),
+      path.sep + path.join('usr', 'local', 'bin', 'command')
+    );
   });
 });

src/assets/move.js

@@ -5,7 +5,6 @@ const { createWriteStream } = require('fs');
  * Move strategy for binary resources without compression.
  */
 function move({ opts, req, onSuccess, onError }) {
-
   const stream = createWriteStream(join(opts.binPath, opts.binName));
 
   stream.on('error', onError);

src/assets/move.spec.js

@@ -6,11 +6,9 @@ const move = require('../../src/assets/move');
 jest.mock('fs');
 
 describe('move()', () => {
-
   let streamEvents, pipe, onSuccess, onError;
 
   beforeEach(() => {
-
     streamEvents = new EventEmitter();
 
     pipe = jest.fn();
@@ -22,26 +20,40 @@ describe('move()', () => {
   });
 
   it('should download resource to given binPath', () => {
-
-    move({ opts: { binPath: './bin', binName: 'command' }, req: { pipe }, onSuccess, onError });
-
-    expect(fs.createWriteStream).toHaveBeenCalledWith(path.join("bin", "command"));
+    move({
+      opts: { binPath: './bin', binName: 'command' },
+      req: { pipe },
+      onSuccess,
+      onError
+    });
+
+    expect(fs.createWriteStream).toHaveBeenCalledWith(
+      path.join('bin', 'command')
+    );
   });
 
   it('should call onSuccess on stream closed', () => {
-
-    move({ opts: { binPath: './bin', binName: 'command' }, req: { pipe }, onSuccess, onError });
+    move({
+      opts: { binPath: './bin', binName: 'command' },
+      req: { pipe },
+      onSuccess,
+      onError
+    });
 
     streamEvents.emit('close');
 
     expect(onSuccess).toHaveBeenCalled();
   });
 
   it('should call onError with error on write stream error', () => {
-
     const error = new Error();
 
-    move({ opts: { binPath: './bin', binName: 'command' }, req: { pipe }, onSuccess, onError });
+    move({
+      opts: { binPath: './bin', binName: 'command' },
+      req: { pipe },
+      onSuccess,
+      onError
+    });
 
     streamEvents.emit('error', error);