Fix incorrect parameter types in shader comparison functions #11239
+30
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only vector float types are allowed for these functions, not scalar floats.
Calinou
added
bug
area:manual
| @@ -1988,7 +1990,7 @@ Comparison function descriptions | |||
|
|
|||
| .. rst-class:: classref-method | |||
|
|
|||
| |vec_bool_type| **lessThan**\ (\ |vec_type| x, |vec_type| y) :ref:`🔗<shader_func_lessThan>` | |||
| |vec_bool_type| **lessThan**\ (\ |vec_type_no_scalar| x, |vec_type_no_scalar| y) :ref:`🔗<shader_func_lessThan>` | |||
There was a problem hiding this comment.
These need to be updated above in 1962-1973
Also this returns bvec which is strictly bvec2, bvec3, bvec4
| +--------------------+-----------------------------------------------------+--------------------------+ | ||
| | vec_uint_type | uint, uvec2, uvec3, or uvec4 | genUType | | ||
| +--------------------+-----------------------------------------------------+--------------------------+ | ||
| | vec_bool_type | bool, bvec2, bvec3, or bvec4 | genBType | |
There was a problem hiding this comment.
These three also need non-gen types, for the methods that take/return bvec/ivec/uvec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only vector float types are allowed for these functions, not scalar floats.