Skip to content

Commit c78ccd5

Browse files
Add a new editor theme
Co-authored-by: passivestar <[email protected]>
1 parent d705613 commit c78ccd5

23 files changed

+4868
-2301
lines changed

COPYRIGHT.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,11 @@ Comment: DroidSans font
273273
Copyright: 2008, The Android Open Source Project
274274
License: Apache-2.0
275275

276+
Files: thirdparty/fonts/Inter*.woff2
277+
Comment: Inter font
278+
Copyright: 2016, The Inter Project
279+
License: OFL-1.1
280+
276281
Files: thirdparty/fonts/JetBrainsMono_Regular.woff2
277282
Comment: JetBrains Mono font
278283
Copyright: 2020, JetBrains s.r.o.

editor/gui/editor_object_selector.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,8 @@ EditorObjectSelector::EditorObjectSelector(EditorSelectionHistory *p_history) {
208208
history = p_history;
209209

210210
MarginContainer *main_mc = memnew(MarginContainer);
211+
main_mc->set_theme_type_variation("ObjectSelectorMargin");
211212
main_mc->set_anchors_and_offsets_preset(PRESET_FULL_RECT);
212-
main_mc->add_theme_constant_override("margin_left", 4 * EDSCALE);
213-
main_mc->add_theme_constant_override("margin_right", 6 * EDSCALE);
214213
add_child(main_mc);
215214

216215
HBoxContainer *main_hb = memnew(HBoxContainer);

editor/project_manager/quick_settings_dialog.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ void QuickSettingsDialog::update_size_limits(const Size2 &p_max_popup_size) {
241241
void QuickSettingsDialog::_notification(int p_what) {
242242
switch (p_what) {
243243
case NOTIFICATION_THEME_CHANGED: {
244-
settings_list_panel->add_theme_style_override(SceneStringName(panel), get_theme_stylebox(SNAME("Background"), EditorStringName(EditorStyles)));
244+
settings_list_panel->add_theme_style_override(SceneStringName(panel), get_theme_stylebox(SNAME("quick_settings_panel"), SNAME("ProjectManager")));
245245

246246
restart_required_label->add_theme_color_override(SceneStringName(font_color), get_theme_color(SNAME("warning_color"), EditorStringName(Editor)));
247247
custom_theme_label->add_theme_color_override(SceneStringName(font_color), get_theme_color(SNAME("font_placeholder_color"), EditorStringName(Editor)));

editor/run/game_view_plugin.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1046,12 +1046,8 @@ GameView::GameView(Ref<GameViewDebugger> p_debugger, EmbeddedProcessBase *p_embe
10461046
window_wrapper = p_wrapper;
10471047
embedded_process = p_embedded_process;
10481048

1049-
// Add some margin to the sides for better aesthetics.
1050-
// This prevents the first button's hover/pressed effect from "touching" the panel's border,
1051-
// which looks ugly.
10521049
MarginContainer *toolbar_margin = memnew(MarginContainer);
1053-
toolbar_margin->add_theme_constant_override("margin_left", 4 * EDSCALE);
1054-
toolbar_margin->add_theme_constant_override("margin_right", 4 * EDSCALE);
1050+
toolbar_margin->set_theme_type_variation("MainToolBarMargin");
10551051
add_child(toolbar_margin);
10561052

10571053
HBoxContainer *main_menu_hbox = memnew(HBoxContainer);

editor/scene/2d/tiles/tile_set_editor.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ void TileSetEditor::_notification(int p_what) {
370370
source_sort_button->set_button_icon(get_editor_theme_icon(SNAME("Sort")));
371371
sources_advanced_menu_button->set_button_icon(get_editor_theme_icon(SNAME("GuiTabMenuHl")));
372372
missing_texture_texture = get_editor_theme_icon(SNAME("TileSet"));
373-
expanded_area->add_theme_style_override(SceneStringName(panel), get_theme_stylebox(SceneStringName(panel), "Tree"));
373+
expanded_area->add_theme_style_override(SceneStringName(panel), get_theme_stylebox(SNAME("expand_panel"), SNAME("TileSetEditor")));
374374
_update_sources_list();
375375
} break;
376376

editor/scene/3d/node_3d_editor_plugin.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9467,12 +9467,8 @@ Node3DEditor::Node3DEditor() {
94679467
snap_key_enabled = false;
94689468
tool_mode = TOOL_MODE_SELECT;
94699469

9470-
// Add some margin to the sides for better aesthetics.
9471-
// This prevents the first button's hover/pressed effect from "touching" the panel's border,
9472-
// which looks ugly.
94739470
MarginContainer *toolbar_margin = memnew(MarginContainer);
9474-
toolbar_margin->add_theme_constant_override("margin_left", 4 * EDSCALE);
9475-
toolbar_margin->add_theme_constant_override("margin_right", 4 * EDSCALE);
9471+
toolbar_margin->set_theme_type_variation("MainToolBarMargin");
94769472
vbc->add_child(toolbar_margin);
94779473

94789474
// A fluid container for all toolbars.

editor/scene/canvas_item_editor_plugin.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5331,12 +5331,8 @@ CanvasItemEditor::CanvasItemEditor() {
53315331
SceneTreeDock::get_singleton()->connect("node_created", callable_mp(this, &CanvasItemEditor::_adjust_new_node_position));
53325332
SceneTreeDock::get_singleton()->connect("add_node_used", callable_mp(this, &CanvasItemEditor::_reset_create_position));
53335333

5334-
// Add some margin to the sides for better aesthetics.
5335-
// This prevents the first button's hover/pressed effect from "touching" the panel's border,
5336-
// which looks ugly.
53375334
MarginContainer *toolbar_margin = memnew(MarginContainer);
5338-
toolbar_margin->add_theme_constant_override("margin_left", 4 * EDSCALE);
5339-
toolbar_margin->add_theme_constant_override("margin_right", 4 * EDSCALE);
5335+
toolbar_margin->set_theme_type_variation("MainToolBarMargin");
53405336
add_child(toolbar_margin);
53415337

53425338
// A fluid container for all toolbars.

editor/scene/gui/theme_editor_plugin.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3482,6 +3482,7 @@ void ThemeTypeEditor::_notification(int p_what) {
34823482
rename_type_button->set_button_icon(get_editor_theme_icon(SNAME("Rename")));
34833483
remove_type_button->set_button_icon(get_editor_theme_icon(SNAME("Remove")));
34843484

3485+
data_type_tabs->add_theme_style_override(SNAME("tabbar_background"), get_theme_stylebox(SNAME("type_tabbar_bg"), SNAME("ThemeEditor")));
34853486
data_type_tabs->set_tab_icon(0, get_editor_theme_icon(SNAME("Color")));
34863487
data_type_tabs->set_tab_icon(1, get_editor_theme_icon(SNAME("MemberConstant")));
34873488
data_type_tabs->set_tab_icon(2, get_editor_theme_icon(SNAME("FontItem")));

editor/settings/editor_settings.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -580,18 +580,19 @@ void EditorSettings::_load_defaults(Ref<ConfigFile> p_extra_config) {
580580

581581
// Theme
582582
EDITOR_SETTING_BASIC(Variant::BOOL, PROPERTY_HINT_ENUM, "interface/theme/follow_system_theme", false, "")
583-
EDITOR_SETTING_BASIC(Variant::STRING, PROPERTY_HINT_ENUM, "interface/theme/preset", "Default", "Default,Breeze Dark,Godot 2,Gray,Light,Solarized (Dark),Solarized (Light),Black (OLED),Custom")
583+
EDITOR_SETTING_BASIC(Variant::STRING, PROPERTY_HINT_ENUM, "interface/theme/style", "Default", "Default,Classic")
584+
EDITOR_SETTING_BASIC(Variant::STRING, PROPERTY_HINT_ENUM, "interface/theme/preset", "Default", "Default,Classic,Breeze Dark,Godot 2,Gray,Light,Solarized (Dark),Solarized (Light),Black (OLED),Custom")
584585
EDITOR_SETTING_BASIC(Variant::STRING, PROPERTY_HINT_ENUM, "interface/theme/spacing_preset", "Default", "Compact,Default,Spacious,Custom")
585586
EDITOR_SETTING(Variant::INT, PROPERTY_HINT_ENUM, "interface/theme/icon_and_font_color", 0, "Auto,Dark,Light")
586-
EDITOR_SETTING_BASIC(Variant::COLOR, PROPERTY_HINT_NONE, "interface/theme/base_color", Color(0.2, 0.23, 0.31), "")
587-
EDITOR_SETTING_BASIC(Variant::COLOR, PROPERTY_HINT_NONE, "interface/theme/accent_color", Color(0.41, 0.61, 0.91), "")
587+
EDITOR_SETTING_BASIC(Variant::COLOR, PROPERTY_HINT_NONE, "interface/theme/base_color", Color(0.14, 0.14, 0.14), "")
588+
EDITOR_SETTING_BASIC(Variant::COLOR, PROPERTY_HINT_NONE, "interface/theme/accent_color", Color(0.34, 0.62, 1.0), "")
588589
EDITOR_SETTING_BASIC(Variant::BOOL, PROPERTY_HINT_NONE, "interface/theme/use_system_accent_color", false, "")
589590
EDITOR_SETTING_BASIC(Variant::FLOAT, PROPERTY_HINT_RANGE, "interface/theme/contrast", 0.3, "-1,1,0.01")
590591
EDITOR_SETTING(Variant::BOOL, PROPERTY_HINT_NONE, "interface/theme/draw_extra_borders", false, "")
591-
EDITOR_SETTING(Variant::FLOAT, PROPERTY_HINT_RANGE, "interface/theme/icon_saturation", 1.0, "0,2,0.01")
592+
EDITOR_SETTING(Variant::FLOAT, PROPERTY_HINT_RANGE, "interface/theme/icon_saturation", 2.0, "0,2,0.01")
592593
EDITOR_SETTING(Variant::FLOAT, PROPERTY_HINT_RANGE, "interface/theme/relationship_line_opacity", 0.1, "0.00,1,0.01")
593594
EDITOR_SETTING(Variant::INT, PROPERTY_HINT_RANGE, "interface/theme/border_size", 0, "0,2,1")
594-
EDITOR_SETTING(Variant::INT, PROPERTY_HINT_RANGE, "interface/theme/corner_radius", 3, "0,6,1")
595+
EDITOR_SETTING(Variant::INT, PROPERTY_HINT_RANGE, "interface/theme/corner_radius", 4, "0,6,1")
595596
EDITOR_SETTING(Variant::INT, PROPERTY_HINT_RANGE, "interface/theme/base_spacing", 4, "0,8,1")
596597
EDITOR_SETTING(Variant::INT, PROPERTY_HINT_RANGE, "interface/theme/additional_spacing", 0, "0,8,1")
597598
EDITOR_SETTING_USAGE(Variant::STRING, PROPERTY_HINT_GLOBAL_FILE, "interface/theme/custom_theme", "", "*.res,*.tres,*.theme", PROPERTY_USAGE_DEFAULT)

editor/themes/editor_fonts.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,8 @@ void editor_register_fonts(const Ref<Theme> &p_theme) {
153153
const int default_font_size = int(EDITOR_GET("interface/editor/main_font_size")) * EDSCALE;
154154
const float embolden_strength = 0.6;
155155

156-
Ref<Font> default_font = load_internal_font(_font_NotoSans_Regular, _font_NotoSans_Regular_size, font_hinting, font_antialiasing, true, font_subpixel_positioning, font_disable_embedded_bitmaps, false);
157-
Ref<Font> default_font_msdf = load_internal_font(_font_NotoSans_Regular, _font_NotoSans_Regular_size, font_hinting, font_antialiasing, true, font_subpixel_positioning, font_disable_embedded_bitmaps, font_allow_msdf);
156+
Ref<Font> default_font = load_internal_font(_font_Inter_Regular, _font_Inter_Regular_size, font_hinting, font_antialiasing, true, font_subpixel_positioning, font_disable_embedded_bitmaps, false);
157+
Ref<Font> default_font_msdf = load_internal_font(_font_Inter_Regular, _font_Inter_Regular_size, font_hinting, font_antialiasing, true, font_subpixel_positioning, font_disable_embedded_bitmaps, font_allow_msdf);
158158

159159
String noto_cjk_path;
160160
String noto_cjk_bold_path;
@@ -188,8 +188,8 @@ void editor_register_fonts(const Ref<Theme> &p_theme) {
188188
default_font->set_fallbacks(fallbacks);
189189
default_font_msdf->set_fallbacks(fallbacks);
190190

191-
Ref<FontFile> default_font_bold = load_internal_font(_font_NotoSans_Bold, _font_NotoSans_Bold_size, font_hinting, font_antialiasing, true, font_subpixel_positioning, font_disable_embedded_bitmaps, false);
192-
Ref<FontFile> default_font_bold_msdf = load_internal_font(_font_NotoSans_Bold, _font_NotoSans_Bold_size, font_hinting, font_antialiasing, true, font_subpixel_positioning, font_disable_embedded_bitmaps, font_allow_msdf);
191+
Ref<FontFile> default_font_bold = load_internal_font(_font_Inter_Bold, _font_Inter_Bold_size, font_hinting, font_antialiasing, true, font_subpixel_positioning, font_disable_embedded_bitmaps, false);
192+
Ref<FontFile> default_font_bold_msdf = load_internal_font(_font_Inter_Bold, _font_Inter_Bold_size, font_hinting, font_antialiasing, true, font_subpixel_positioning, font_disable_embedded_bitmaps, font_allow_msdf);
193193

194194
TypedArray<Font> fallbacks_bold;
195195
Ref<FontFile> arabic_font_bold = load_internal_font(_font_Vazirmatn_Bold, _font_Vazirmatn_Bold_size, font_hinting, font_antialiasing, true, font_subpixel_positioning, font_disable_embedded_bitmaps, false, &fallbacks_bold);

0 commit comments

Comments
 (0)