Skip to content

Commit 65ef314

Browse files
committed
net/http: remove unused linknames
These were removed in: gobwas/ws@8e2d520 For #67401 Change-Id: I44898beb6fa3b6867b3d2164fc930724e143cf30 Reviewed-on: https://go-review.googlesource.com/c/go/+/721200 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Damien Neil <[email protected]> Reviewed-by: Mark Freeman <[email protected]>
1 parent 0f32fbc commit 65ef314

File tree

1 file changed

+0
-36
lines changed

1 file changed

+0
-36
lines changed

src/net/http/server.go

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -854,15 +854,6 @@ func bufioWriterPool(size int) *sync.Pool {
854854
return nil
855855
}
856856

857-
// newBufioReader should be an internal detail,
858-
// but widely used packages access it using linkname.
859-
// Notable members of the hall of shame include:
860-
// - github.com/gobwas/ws
861-
//
862-
// Do not remove or change the type signature.
863-
// See go.dev/issue/67401.
864-
//
865-
//go:linkname newBufioReader
866857
func newBufioReader(r io.Reader) *bufio.Reader {
867858
if v := bufioReaderPool.Get(); v != nil {
868859
br := v.(*bufio.Reader)
@@ -874,29 +865,11 @@ func newBufioReader(r io.Reader) *bufio.Reader {
874865
return bufio.NewReader(r)
875866
}
876867

877-
// putBufioReader should be an internal detail,
878-
// but widely used packages access it using linkname.
879-
// Notable members of the hall of shame include:
880-
// - github.com/gobwas/ws
881-
//
882-
// Do not remove or change the type signature.
883-
// See go.dev/issue/67401.
884-
//
885-
//go:linkname putBufioReader
886868
func putBufioReader(br *bufio.Reader) {
887869
br.Reset(nil)
888870
bufioReaderPool.Put(br)
889871
}
890872

891-
// newBufioWriterSize should be an internal detail,
892-
// but widely used packages access it using linkname.
893-
// Notable members of the hall of shame include:
894-
// - github.com/gobwas/ws
895-
//
896-
// Do not remove or change the type signature.
897-
// See go.dev/issue/67401.
898-
//
899-
//go:linkname newBufioWriterSize
900873
func newBufioWriterSize(w io.Writer, size int) *bufio.Writer {
901874
pool := bufioWriterPool(size)
902875
if pool != nil {
@@ -909,15 +882,6 @@ func newBufioWriterSize(w io.Writer, size int) *bufio.Writer {
909882
return bufio.NewWriterSize(w, size)
910883
}
911884

912-
// putBufioWriter should be an internal detail,
913-
// but widely used packages access it using linkname.
914-
// Notable members of the hall of shame include:
915-
// - github.com/gobwas/ws
916-
//
917-
// Do not remove or change the type signature.
918-
// See go.dev/issue/67401.
919-
//
920-
//go:linkname putBufioWriter
921885
func putBufioWriter(bw *bufio.Writer) {
922886
bw.Reset(nil)
923887
if pool := bufioWriterPool(bw.Available()); pool != nil {

0 commit comments

Comments
 (0)