optimize the performance of the function appendFormatRFC3339

Author: fx408

src/time/export_test.go

@@ -134,6 +134,8 @@ var StdChunkNames = map[int]string{
 var Quote = quote
 
 var AppendInt = appendInt
+var AppendIntWidth2 = appendIntWidth2
+var AppendIntWidth4 = appendIntWidth4
 var AppendFormatAny = Time.appendFormat
 var AppendFormatRFC3339 = Time.appendFormatRFC3339
 var ParseAny = parse

src/time/format.go

@@ -470,6 +470,7 @@ const tensDigit = "00000000001111111111222222222233333333334444444444" +
 	"55555555556666666666777777777788888888889999999999"
 
 // appendIntWidth2 special scenario for appendInt, with parameter width=2
+// Only applicable to integers with absolute value less than 100
 func appendIntWidth2(b []byte, x int) []byte {
 	if x < 0 {
 		b = append(b, '-')
@@ -488,7 +489,7 @@ func appendIntWidth4(b []byte, x int) []byte {
 		x = -x
 	}
 	if x >= 1e4 {
-		x %= 1e4
+		return appendInt(b, x, 4)
 	}
 	return append(b, tensDigit[x/1e2], unitsDigit[x/1e2], tensDigit[x%1e2], unitsDigit[x%1e2])
 }

src/time/format_test.go

@@ -1091,3 +1091,70 @@ func FuzzParseRFC3339(f *testing.F) {
 		}
 	})
 }
+
+func TestAppendIntWidth(t *testing.T) {
+	values := []int{0, -1, 1, 10, -10, 99, -99}
+	for _, v := range values {
+		exp := AppendInt(nil, v, 2)
+		got := AppendIntWidth2(nil, v)
+		if !bytes.Equal(got, exp) {
+			t.Errorf("AppendIntWidth2(%d) = %s, want %s", v, got, exp)
+		}
+	}
+
+	got := AppendIntWidth2(nil, 199)
+	if !bytes.Equal(got, []byte("99")) {
+		t.Errorf("AppendIntWidth2(199) = %s, want %s", got, []byte("99"))
+	}
+
+	values = append(values, 9999, -9999, 10001)
+	for _, v := range values {
+		exp := AppendInt(nil, v, 4)
+		got := AppendIntWidth4(nil, v)
+		if !bytes.Equal(got, exp) {
+			t.Errorf("AppendIntWidth4(%d) = %s, want %s", v, got, exp)
+		}
+	}
+}
+
+func BenchmarkAppendIntWidth2(b *testing.B) {
+	b.Run("name=AppendInt", func(b *testing.B) {
+		var buf = make([]byte, 0, 8)
+		b.ResetTimer()
+		for i := 0; i < b.N; i++ {
+			buf = AppendInt(buf[:0], 36, 2)
+		}
+	})
+	b.Run("name=AppendIntWidth2", func(b *testing.B) {
+		var buf = make([]byte, 0, 8)
+		b.ResetTimer()
+		for i := 0; i < b.N; i++ {
+			buf = AppendIntWidth2(buf[:0], 36)
+		}
+	})
+}
+
+func BenchmarkAppendIntWidth4(b *testing.B) {
+	b.Run("name=AppendInt", func(b *testing.B) {
+		var buf = make([]byte, 0, 8)
+		b.ResetTimer()
+		for i := 0; i < b.N; i++ {
+			buf = AppendInt(buf[:0], 360, 4)
+		}
+	})
+	b.Run("name=AppendIntWidth4", func(b *testing.B) {
+		var buf = make([]byte, 0, 8)
+		b.ResetTimer()
+		for i := 0; i < b.N; i++ {
+			buf = AppendIntWidth4(buf[:0], 360)
+		}
+	})
+}
+
+func BenchmarkTimeFormatRFC3339(b *testing.B) {
+	tm := Now()
+	buf := make([]byte, 0, 64)
+	for i := 0; i < b.N; i++ {
+		buf = tm.AppendFormat(buf[:0], RFC3339)
+	}
+}