cmd/gorename: log 'go build' output on failure

Bryan C. Mills · Bryan Mills · commit 3fca6a08d78f · 2021-12-08T16:15:56.000Z
For golang/go#50043 Change-Id: I90d1e85c59d6f9c9ad30edf0180cb876c2564534 Reviewed-on: https://go-review.googlesource.com/c/tools/+/370254 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
diff --git a/cmd/gorename/gorename_test.go b/cmd/gorename/gorename_test.go
@@ -331,8 +331,8 @@ func buildGorename(t *testing.T) (tmp, bin string, cleanup func()) {
 		bin += ".exe"
 	}
 	cmd := exec.Command("go", "build", "-o", bin)
-	if err := cmd.Run(); err != nil {
-		t.Fatalf("Building gorename: %v", err)
+	if out, err := cmd.CombinedOutput(); err != nil {
+		t.Fatalf("Building gorename: %v\n%s", err, out)
 	}
 	return tmp, bin, func() { os.RemoveAll(tmp) }
 }

Original file line number	Diff line number	Diff line change
`@@ -331,8 +331,8 @@ func buildGorename(t *testing.T) (tmp, bin string, cleanup func()) {`
`331`	`331`	`bin += ".exe"`
`332`	`332`	`}`
`333`	`333`	`cmd := exec.Command("go", "build", "-o", bin)`
`334`		`- if err := cmd.Run(); err != nil {`
`335`		`- t.Fatalf("Building gorename: %v", err)`
	`334`	`+ if out, err := cmd.CombinedOutput(); err != nil {`
	`335`	`+ t.Fatalf("Building gorename: %v\n%s", err, out)`
`336`	`336`	`}`
`337`	`337`	`return tmp, bin, func() { os.RemoveAll(tmp) }`
`338`	`338`	`}`