Skip to content

Commit 7fd8e3d

Browse files
h9jianggopherbot
authored andcommitted
extension/src: show output channel upon failure
CL 559738 changes the type of output channel to log output channel. The log output channel does not show by default. The extension will only show the output channel upon failure, show information message upon success. For #3359 Change-Id: Id4bb8ff053748c80ac3192db34aed0c4c9c5acec Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/691615 Auto-Submit: Hongxiang Jiang <[email protected]> Reviewed-by: Madeline Kalil <[email protected]> kokoro-CI: kokoro <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 0baf320 commit 7fd8e3d

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

extension/src/goInstall.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,13 @@ export const installCurrentPackage: CommandFactory = () => async () => {
6060

6161
outputChannel.appendLine(`Installing ${importPath === '.' ? 'current package' : importPath}`);
6262

63-
cp.execFile(goRuntimePath, args, { env, cwd }, (err, stdout, stderr) => {
63+
cp.execFile(goRuntimePath, args, { env, cwd }, (err, _, stderr) => {
6464
if (err) {
6565
outputChannel.error(`Installation failed: ${stderr}`);
66+
outputChannel.show();
6667
} else {
6768
outputChannel.appendLine('Installation successful');
69+
vscode.window.showInformationMessage('Installation successful');
6870
}
6971
});
7072
};

0 commit comments

Comments
 (0)