Resolve many concurrency warnings #349
Conversation
There was a problem hiding this comment.
Thanks for your contribution! I agree with the overall goal of making this package fully compatible with Swift 6. However, it would be helpful to break the changes into separate, meaningful commits and provide an example with each commit explaining how it addresses a specific issue. This will help streamline the merging process and make it easier to review.
Thanks again!
|
|
||
| public func makeImage(url: URL?) -> some View { | ||
| if let url = url, let image = self.image(url: url) { | ||
| if let url, let image = self.image(url: url) { |
There was a problem hiding this comment.
This is unrelated to the concurrency.
| } | ||
|
|
||
| private var widthStorage: AnyHashable? | ||
| nonisolated(unsafe) private var widthStorage: AnyHashable? // Marking this as `nonisolated(unsafe)`, because it should really be `Font.Width?`, but this is only available from iOS 16. Change to type `Font.Width?` and remove `nonisolated(unsafe)` after raising minimum target to iOS 16 |
There was a problem hiding this comment.
We may be able to define an adapter for this instead of raising the minimum platform version.
|
@MojtabaHs, @gonzalezreal has already said that he's working on his own solution for Swift 6 compatibility. However, I'm not sure how you would break this into separate commits. This PR is meant as a starting point, and perhaps it won't even be used in the end. You can do with it what you like. |
This is a first attempt to resolve many concurrency warnings in preparation for strict concurrency with Swift 6.0. It depends on the changes I made in NetworkImage here: gonzalezreal/NetworkImage#33
I'm still unsure how to resolve the warnings related to the four instances of
static var defaultValue, structs conforming toImageProvider, andcmarkinMarkdownParser.swift.