Skip to content

fix(spec): remove duplicate "id" key from big_blueprint fixture - #2097

Merged
alexole01 merged 1 commit into
masterfrom
aole-GRIF-1141-fix-blueprint-fixture
Oct 5, 2026
Merged

alexole01 merged 1 commit into
masterfrom
aole-GRIF-1141-fix-blueprint-fixture

Conversation

@alexole01

@alexole01 alexole01 commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • spec/data/blueprints/big_blueprint_not_pruned.json: the attr.stage.issao attribute object carried a stray second "id": "label.stage.issao" line, copied from the label object right after it. Remove it (one line).
  • Older json gems silently kept the last duplicate value; json 3.0 (released 2026-09-07) raises JSON::ParserError: duplicate key "id". Nothing pins json here (no Gemfile.lock), so since September every spec that loads this fixture fails and pre-merge is red for every PR — e.g. chore(renovate): onboard to the shared GoodData preset (GRIF-1141) #2096: unit-tests (3.2.1) → 10 failures in to_wire_spec.rb, the rest of the matrix cancelled by fail-fast.
  • The remaining id matches the expected wire model (spec/data/wire_models/model_view.json: attribute attr.stage.issao, default label label.stage.issao), so this restores the intended data rather than working around the parser.

Part of GRIF-1141 (unblocks the Renovate onboarding PR #2096).

Test plan

  • bundle exec rake test:unit under Ruby 3.2.1 with freshly resolved gems (json 3.0.2): 650 examples, 0 failures (was 650 / 10 failures on master)
  • pre-merge matrix green in CI: all 7 unit-tests jobs (2.5 … 3.2.1, jruby 9.2–9.4) pass, ready-to-merge passes; fossa-native fails with the shared action's Maven-settings error seen on unrelated PRs today, not related to this change

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated a blueprint’s stage attribute declaration; its label remains available separately.

The attr.stage.issao attribute object carried a stray second
"id": "label.stage.issao" line copied from the label object that
follows it. Older json gems silently kept the last value; json 3.0
(2026-09) rejects duplicate keys, so every spec loading this fixture
failed with JSON::ParserError and pre-merge has been red since.

The remaining id matches spec/data/wire_models/model_view.json
(attribute attr.stage.issao, label label.stage.issao).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 4db4a725-eb5b-4bc9-bf45-8bc480c3f6f9
📥 Commits

Reviewing files that changed from the base of the PR and between 12fd89e and 43b5800.

📒 Files selected for processing (1)
  • spec/data/blueprints/big_blueprint_not_pruned.json

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The attr.stage.issao declaration in the blueprint data no longer includes the id property. Its folder property remains.

Changes

Blueprint attribute declaration

Layer / File(s) Summary
Update attribute declaration
spec/data/blueprints/big_blueprint_not_pruned.json
The attr.stage.issao entry drops its id property. Its folder property remains.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 43b58

The fixture now retains the expected attribute and label relationship, with no merge-blocking issue identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing a duplicate "id" key from the blueprint fixture.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

I’m a rabbit, hopping by,
I saw one field go passing by.
The folder stays, the ID is gone,
I nibble clover, then hop on.
The blueprint rests beneath the sun.

Comment @coderabbitai help to get the list of available commands.

@zhabba zhabba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexole01
alexole01 added this pull request to the merge queue Oct 5, 2026
Merged via the queue into master with commit d7c808b Oct 5, 2026
27 of 28 checks passed
@alexole01
alexole01 deleted the aole-GRIF-1141-fix-blueprint-fixture branch October 5, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants