Repository navigation
fix(spec): remove duplicate "id" key from big_blueprint fixture - #2097
Conversation
The attr.stage.issao attribute object carried a stray second "id": "label.stage.issao" line copied from the label object that follows it. Older json gems silently kept the last value; json 3.0 (2026-09) rejects duplicate keys, so every spec loading this fixture failed with JSON::ParserError and pre-merge has been red since. The remaining id matches spec/data/wire_models/model_view.json (attribute attr.stage.issao, label label.stage.issao). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe ChangesBlueprint attribute declaration
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The fixture now retains the expected attribute and label relationship, with no merge-blocking issue identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
I’m a rabbit, hopping by, Comment |
Summary
spec/data/blueprints/big_blueprint_not_pruned.json: theattr.stage.issaoattribute object carried a stray second"id": "label.stage.issao"line, copied from the label object right after it. Remove it (one line).jsongems silently kept the last duplicate value;json3.0 (released 2026-09-07) raisesJSON::ParserError: duplicate key "id". Nothing pinsjsonhere (noGemfile.lock), so since September every spec that loads this fixture fails andpre-mergeis red for every PR — e.g. chore(renovate): onboard to the shared GoodData preset (GRIF-1141) #2096:unit-tests (3.2.1)→ 10 failures into_wire_spec.rb, the rest of the matrix cancelled by fail-fast.spec/data/wire_models/model_view.json: attributeattr.stage.issao, default labellabel.stage.issao), so this restores the intended data rather than working around the parser.Part of GRIF-1141 (unblocks the Renovate onboarding PR #2096).
Test plan
bundle exec rake test:unitunder Ruby 3.2.1 with freshly resolved gems (json3.0.2): 650 examples, 0 failures (was 650 / 10 failures on master)pre-mergematrix green in CI: all 7unit-testsjobs (2.5 … 3.2.1, jruby 9.2–9.4) pass,ready-to-mergepasses;fossa-nativefails with the shared action's Maven-settings error seen on unrelated PRs today, not related to this change🤖 Generated with Claude Code
Summary by CodeRabbit