Commit 0cb0ca7
committed
fix: follow redirects when downloading skills in GcpSkillRegistry
The Agent Registry media download endpoint (alt=media) responds with a
302 redirect to a short-lived GCS signed URL instead of streaming the
archive directly. httpx does not follow redirects by default and its
raise_for_status() raises on 3xx responses, so _make_request treated
the 302 as a failure and get_skill() could never download the skill
archive.
Following redirects is safe here: httpx drops the Authorization header
on cross-origin redirects, so the OAuth token is not forwarded to the
signed-URL host (GCS would reject a signed URL carrying extra
credentials anyway).1 parent e4ba704 commit 0cb0ca7
2 files changed
Lines changed: 29 additions & 3 deletions
File tree
- src/google/adk/integrations/skill_registry
- tests/unittests/integrations/skill_registry
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
157 | 161 | | |
158 | | - | |
159 | | - | |
| 162 | + | |
| 163 | + | |
160 | 164 | | |
161 | 165 | | |
162 | 166 | | |
| |||
Lines changed: 23 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
455 | 456 | | |
456 | 457 | | |
457 | 458 | | |
458 | | - | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
459 | 462 | | |
460 | 463 | | |
461 | 464 | | |
| |||
491 | 494 | | |
492 | 495 | | |
493 | 496 | | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
0 commit comments