Skip to content

Commit be3f42f

Browse files
Incorporate feedback from PR review
1 parent 03d41e5 commit be3f42f

File tree

3 files changed

+6
-16
lines changed

3 files changed

+6
-16
lines changed

.github/workflows/graaljs-react-ssr.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525

2626
- uses: graalvm/setup-graalvm@v1
2727
with:
28-
java-version: '24.0.0'
28+
java-version: '24.0.2'
2929
distribution: 'graalvm'
3030
github-token: ${{ secrets.GITHUB_TOKEN }}
3131
cache: 'maven'
@@ -38,5 +38,5 @@ jobs:
3838
3939
- name: Verify application is running
4040
run: |
41-
sleep 30
41+
sleep 10
4242
curl --fail-with-body --silent --dump-header - -o /dev/null http://localhost:8080

graaljs/graaljs-react-ssr/pom.xml

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -54,25 +54,13 @@
5454
<dependency>
5555
<groupId>org.graalvm.js</groupId>
5656
<artifactId>js-language</artifactId>
57-
<version>24.2.1</version>
57+
<version>24.2.2</version>
5858
<scope>runtime</scope>
5959
</dependency>
6060
<dependency>
6161
<groupId>org.graalvm.polyglot</groupId>
6262
<artifactId>polyglot</artifactId>
63-
<version>24.2.1</version>
64-
<scope>runtime</scope>
65-
</dependency>
66-
<dependency>
67-
<groupId>org.graalvm.truffle</groupId>
68-
<artifactId>truffle-enterprise</artifactId>
69-
<version>24.2.1</version>
70-
<scope>runtime</scope>
71-
</dependency>
72-
<dependency>
73-
<groupId>org.graalvm.truffle</groupId>
74-
<artifactId>truffle-runtime</artifactId>
75-
<version>24.2.1</version>
63+
<version>24.2.2</version>
7664
<scope>runtime</scope>
7765
</dependency>
7866
<dependency>

graaljs/graaljs-react-ssr/src/main/js/components/SimpleLineChart.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import React from 'react';
22
import { LineChart, Line, CartesianGrid, XAxis, YAxis, Tooltip, Legend, ResponsiveContainer } from 'recharts';
33

4+
// Original line chart example from Recharts:
5+
// https://recharts.org/en-US/examples/SimpleLineChart
46
const data = [
57
{ name: 'A', uv: 400, pv: 240 },
68
{ name: 'B', uv: 300, pv: 456 },

0 commit comments

Comments
 (0)