Skip to content

Commit 64fec82

Browse files
committed
Serve reports using Rails rather than Webrick.
1 parent f602638 commit 64fec82

File tree

12 files changed

+20
-28
lines changed

12 files changed

+20
-28
lines changed

Gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ group :development do
7676
gem "pry-rails"
7777
gem "rubocop-shopify", require: false
7878
gem "ruby-lsp", require: false
79-
gem "webrick"
8079
gem "web-console"
8180

8281
# Vendoring external assets.

Gemfile.lock

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,6 @@ GEM
353353
activemodel (>= 6.0.0)
354354
bindex (>= 0.4.0)
355355
railties (>= 6.0.0)
356-
webrick (1.9.1)
357356
websocket-driver (0.7.7)
358357
base64
359358
websocket-extensions (>= 0.1.0)
@@ -400,7 +399,6 @@ DEPENDENCIES
400399
stackprof
401400
translate_enum
402401
web-console
403-
webrick
404402

405403
RUBY VERSION
406404
ruby 3.2.2p53

Procfile.dev

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
web: env RUBY_DEBUG_OPEN=true bin/rails server -p 3000
22
worker: bin/jobs
33
reloader: bin/reloader
4-
reports: bin/reports_server

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,8 @@ using RVM. Then run `bin/setup` to install the appropriate gems and set things u
153153

154154
The top-level `bin/rails` proxies all Rails commands to the test project, so you can operate it via
155155
the usual commands (e.g., `rails test`, `rails console`). For development, use `bin/dev` to run the
156-
web server and the job queue, which serves the test app and coverage/brakeman reports:
156+
web server and the job queue, which serves the test app and coverage/brakeman reports:
157157

158158
- Test App: [http://127.0.0.1:3000](http://127.0.0.1:3000)
159-
- Test App API: [http://127.0.0.1:3000/api](http://127.0.0.1:3000/api)
160-
- Reports: [http://127.0.0.1:3001](http://127.0.0.1:3001)
159+
- API: [http://127.0.0.1:3000/api](http://127.0.0.1:3000/api)
160+
- Reports: [http://127.0.0.1:3000/reports](http://127.0.0.1:3000/reports)

bin/reloader

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def reload(skip_seed: false)
2323
system("kill -USR1 $(cat #{PUMA_PID_PATH})")
2424

2525
# Run the test suite (generates coverage report).
26-
system("#{"SKIP_SEED=1" if skip_seed} bin/rails test".strip)
26+
system("#{"SKIP_SEED=1" if skip_seed} SIMPLECOV_INLINE_ASSETS=1 bin/rails test".strip)
2727

2828
# Generate brakeman report.
2929
system("bin/brakeman")

bin/reports_server

Lines changed: 0 additions & 5 deletions
This file was deleted.

config/brakeman.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
---
22
:output_files:
3-
- reports/brakeman.html
3+
- test/public/reports/brakeman.html
44
:combine_locations: false

reports/.gitignore

Lines changed: 0 additions & 2 deletions
This file was deleted.

reports/index.html

Lines changed: 0 additions & 11 deletions
This file was deleted.

test/config/simplecov_setup.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
# The `rest_framework` project directory should be the root for coverage purposes.
2121
root ".."
22-
coverage_dir "reports/coverage"
22+
coverage_dir "test/public/reports/coverage"
2323

2424
# Filter out everything but the lib directory.
2525
add_filter "app/"

0 commit comments

Comments
 (0)