Skip to content

Commit 216403a

Browse files
committed
working on test
1 parent 9f124f1 commit 216403a

File tree

3 files changed

+497
-460
lines changed

3 files changed

+497
-460
lines changed

xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import static com.google.common.base.Preconditions.checkNotNull;
2020
import static io.grpc.xds.XdsLbPolicies.PRIORITY_POLICY_NAME;
2121

22-
import com.google.common.annotations.VisibleForTesting;
2322
import com.google.common.collect.ImmutableMap;
2423
import io.grpc.Attributes;
2524
import io.grpc.EquivalentAddressGroup;
@@ -73,11 +72,6 @@ final class ClusterResolverLoadBalancer extends LoadBalancer {
7372
private final LoadBalancer delegate;
7473
private ClusterState clusterState;
7574

76-
ClusterResolverLoadBalancer(Helper helper) {
77-
this(helper, LoadBalancerRegistry.getDefaultRegistry());
78-
}
79-
80-
@VisibleForTesting
8175
ClusterResolverLoadBalancer(Helper helper, LoadBalancerRegistry lbRegistry) {
8276
this.delegate = lbRegistry.getProvider(PRIORITY_POLICY_NAME).newLoadBalancer(helper);
8377
this.lbRegistry = checkNotNull(lbRegistry, "lbRegistry");

xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancerProvider.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import io.grpc.LoadBalancer;
2626
import io.grpc.LoadBalancer.Helper;
2727
import io.grpc.LoadBalancerProvider;
28+
import io.grpc.LoadBalancerRegistry;
2829
import io.grpc.NameResolver.ConfigOrError;
2930
import io.grpc.Status;
3031
import io.grpc.xds.EnvoyServerProtoData.OutlierDetection;
@@ -41,6 +42,15 @@
4142
*/
4243
@Internal
4344
public final class ClusterResolverLoadBalancerProvider extends LoadBalancerProvider {
45+
private final LoadBalancerRegistry lbRegistry;
46+
47+
public ClusterResolverLoadBalancerProvider() {
48+
this.lbRegistry = null;
49+
}
50+
51+
ClusterResolverLoadBalancerProvider(LoadBalancerRegistry lbRegistry) {
52+
this.lbRegistry = checkNotNull(lbRegistry, "lbRegistry");
53+
}
4454

4555
@Override
4656
public boolean isAvailable() {
@@ -65,7 +75,11 @@ public ConfigOrError parseLoadBalancingPolicyConfig(Map<String, ?> rawLoadBalanc
6575

6676
@Override
6777
public LoadBalancer newLoadBalancer(Helper helper) {
68-
return new ClusterResolverLoadBalancer(helper);
78+
LoadBalancerRegistry lbRegistry = this.lbRegistry;
79+
if (lbRegistry == null) {
80+
lbRegistry = LoadBalancerRegistry.getDefaultRegistry();
81+
}
82+
return new ClusterResolverLoadBalancer(helper, lbRegistry);
6983
}
7084

7185
static final class ClusterResolverConfig {

0 commit comments

Comments
 (0)