otel: subchannel metrics #12202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

AgraVator merged 12 commits into grpc:master from AgraVator:otel-subchannel-metrics

Sep 8, 2025

Contributor

AgraVator commented Jul 7, 2025 •

edited

Loading

Implements A94

AgraVator marked this pull request as ready for review

July 9, 2025 10:05

AgraVator requested review from ejona86 and kannanjgithub

July 9, 2025 10:05

AgraVator force-pushed the otel-subchannel-metrics branch from eabbf58 to 9595507 Compare

July 15, 2025 10:00

AgraVator commented

View reviewed changes

core/src/main/java/io/grpc/internal/InternalSubchannel.java Outdated Show resolved Hide resolved

AgraVator added 8 commits

July 22, 2025 23:25


          otel: subchannel metrics

a06568c


          otel: add LongUpDownCounterMetricInstrument

daf901b


          otel: add LongUpDownCounterMetricInstrument

735665b


          otel: plumb optional labels other than disconnect_error

a664b2f


          otel: fixes NPE

2ce087e


          otel: formatting fixes

2293e7f


          add test case

623c0f9


          logs the metrics inside sync context

c713561

AgraVator force-pushed the otel-subchannel-metrics branch from 9595507 to c713561 Compare

July 22, 2025 17:55

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/ManagedChannelImpl.java Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/InternalSubchannel.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/InternalSubchannel.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/DelayedClientTransport.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/InternalSubchannel.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/MetricRecorderImpl.java Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricSink.java Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

api/src/main/java/io/grpc/MetricInstrumentRegistry.java Show resolved Hide resolved


          reframe comments

ca8e9ed

ejona86 reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/MetricRecorderImpl.java Show resolved Hide resolved

core/src/main/java/io/grpc/internal/InternalSubchannel.java Outdated Show resolved Hide resolved

core/src/main/java/io/grpc/internal/OtelMetricsAttributes.java Outdated Show resolved Hide resolved

core/src/main/java/io/grpc/internal/SubchannelMetrics.java Outdated Show resolved Hide resolved

api/src/main/java/io/grpc/LoadBalancer.java Outdated Show resolved Hide resolved


          suggested changes

b45a907

AgraVator requested review from ejona86 and kannanjgithub

July 29, 2025 09:17

kannanjgithub requested changes

View reviewed changes

Contributor

kannanjgithub left a comment

.

opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricSink.java Show resolved Hide resolved


          LongUpDownCounter: add test case

kannanjgithub approved these changes

View reviewed changes

ejona86 approved these changes

View reviewed changes

core/src/main/java/io/grpc/internal/SubchannelMetrics.java Outdated Show resolved Hide resolved

api/src/main/java/io/grpc/EquivalentAddressGroup.java Outdated Show resolved Hide resolved


          use parameterName

d407cfa

ejona86 approved these changes

View reviewed changes

AgraVator merged commit d4e1b69 into grpc:master

16 checks passed

jdcormie pushed a commit to jdcormie/grpc-java that referenced this pull request


          otel: subchannel metrics A94 (grpc#12202)

071e03d

Implements [A94](https://github.com/grpc/proposal/pull/485/files) except for the exact reason for disconnect_error

ejona86 mentioned this pull request

xds: Convert ClusterResolverLb to XdsDepManager #12361

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet