Skip to content

Conversation

eak12913
Copy link
Contributor

[skip ci] Removing former Grunts

@eak12913 eak12913 requested a review from brikis98 as a code owner July 14, 2023 15:09
@@ -1 +1 @@
* @brikis98 @pete0emerson

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho remove all, way to much formalism for such repo :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um... this is such a critical repo for so many modules. Why do you think it needs LESS safeguards?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this codeowners file is repo wide, not per folder.
any repowide codeowners can be done as gh repo config. right?
codeowners is useless here.

also codeowners does not state who allowed to modify code,
but gh tf config does.
more people can modify than listed in codeowners.

Copy link

@dzmitry-lahoda dzmitry-lahoda Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #64

in reality none codeowners looked or approved and yet merged.
so codeowners useless process here.

codeowners mostly for monorepos. this is not monorepo.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working sadeguard is LESS safeguards actually.
removing will add more by not obscuring reality.

so i suggest more security actually;) also gh tf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants