Expose traffic policy configuration for service (#148)

* Add service configuration for traffic policies

* Add test to verify that traffic policy is included in k8s service definition

* Add documentation for new service fields

Author: denis256

charts/k8s-service/templates/service.yaml

@@ -33,6 +33,12 @@ spec:
   selector:
     app.kubernetes.io/name: {{ include "k8s-service.name" . }}
     app.kubernetes.io/instance: {{ .Release.Name }}
+  {{- if .Values.service.externalTrafficPolicy }}
+  externalTrafficPolicy: {{ .Values.service.externalTrafficPolicy }}
+  {{- end}}
+  {{- if .Values.service.internalTrafficPolicy }}
+  internalTrafficPolicy: {{ .Values.service.internalTrafficPolicy }}
+  {{- end}}
   {{- if .Values.service.sessionAffinity }}
   sessionAffinity: {{ .Values.service.sessionAffinity }}
   {{- if .Values.service.sessionAffinityConfig }}

charts/k8s-service/values.yaml

@@ -312,6 +312,10 @@ minPodsAvailable: 0
 #                                       Kubernetes defaults to None.
 #   - sessionAffinityConfig (object)  : Configuration for session affinity, as defined in Kubernetes
 #                                       (https://kubernetes.io/docs/concepts/services-networking/service/#virtual-ips-and-service-proxies)
+#   - externalTrafficPolicy (string)  : Configuration to control traffic flow from external sources - supports 'Cluster' and 'Local'
+#                                       https://kubernetes.io/docs/concepts/services-networking/service/#external-traffic-policy
+#   - internalTrafficPolicy (string)  : Configuration to control traffic flow from internal sources - supports 'Cluster' and 'Local'
+#                                       https://kubernetes.io/docs/concepts/services-networking/service/#internal-traffic-policy
 #
 # The following example uses the default config and enables client IP based session affinity with a maximum session
 # sticky time of 3 hours.
@@ -325,6 +329,8 @@ minPodsAvailable: 0
 #       targetPort: http
 #       protocol: TCP
 #   sessionAffinity: ClientIP
+#   externalTrafficPolicy: Cluster
+#   internalTrafficPolicy: Cluster
 #   sessionAffinityConfig:
 #     clientIP:
 #       timeoutSeconds: 10800

test/k8s_service_template_test.go

@@ -977,6 +977,34 @@ func TestK8SServiceSessionAffinityConfig(t *testing.T) {
 	assert.Equal(t, int32(10800), *service.Spec.SessionAffinityConfig.ClientIP.TimeoutSeconds)
 }
 
+// Test that externalTrafficPolicy is correctly set
+func TestK8SServiceExternalTrafficPolicy(t *testing.T) {
+	t.Parallel()
+
+	service := renderK8SServiceWithSetValues(
+		t,
+		map[string]string{
+			"service.externalTrafficPolicy": "Local",
+		},
+	)
+
+	assert.Equal(t, corev1.ServiceExternalTrafficPolicyType("Local"), service.Spec.ExternalTrafficPolicy)
+}
+
+// Test that internalTrafficPolicy is correctly set
+func TestK8SServiceInternalTrafficPolicy(t *testing.T) {
+	t.Parallel()
+
+	service := renderK8SServiceWithSetValues(
+		t,
+		map[string]string{
+			"service.internalTrafficPolicy": "Local",
+		},
+	)
+
+	assert.Equal(t, corev1.ServiceInternalTrafficPolicyType("Local"), *service.Spec.InternalTrafficPolicy)
+}
+
 // Test that sessionAffinity and sessionAffinityConfig are not rendered if not set
 func TestK8SServiceSessionAffinityOnlySetIfDefined(t *testing.T) {
 	t.Parallel()