-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add support for Azure Database for MySQL - Flexible Server #1245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for Azure Database for MySQL - Flexible Server #1245
Conversation
…/azure/README.md.
|
Tried to run tests, and noticed that fails |
Sorry for the inconvenient! Should be fixed now. |
|
@denis256 Let me know if there is anything else that there is need to be done. Unfortunately I cannot trigger any circleci build |
|
Hey @denis256 sorry to disturb you but I was wondering if this PR will be approved or needs further adjustment. Thanks! |
|
Hi @denis256, any update on this? |
| return &flexibleMySqlServer, nil | ||
| } | ||
|
|
||
| // GetMySqlFlexibleDBClientE is a helper function that will setup a MySql flexible DB client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetMySqlFlexibleServerDBClientE
|
Hi, it is still not clear status of this PR:
|
Hi @denis256, I have resolved merge conflicts. |
|
HI @denis256, @supertrampr, I'm currently facing a similar issue because the current version doesn't support MySQL Flexible Server. Can we retake this PR? or should I create a new one? Thank you! |
|
Hi @baquintanag, I see there are some conflicts. I guess that is because my PR is a little bit old :D I'll try to fix them and see if @denis256 can approve it. |
Description
Fixes #1230.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added MySQL Flexible Server tests. [X]
Updated version of azure-sdk-go from 50.2.0 to 57.1.0. [X]
Migration Guide