Merge pull request #8 from vltansky/tests

tests: throw errors & -r=7 & unexpected error

Author: roblarsen

cli.js

@@ -24,15 +24,12 @@ module.exports = async () => {
     }catch(err){
         await fs.remove(tempDir);
         if(err.code === 'ETARGET'){
-            spinner.fail(chalk.red(`version '${err.wanted}' not found in npm registry\navailable versions:`));
-            console.log(err.versions.reverse().join(' | '));
-            process.exit(1);
-        }/* istanbul ignore next */else{
-            spinner.fail('Unexpected error');
-            console.error(err);
-            process.exit(-1);
-        };
-        return;
+            const msg = chalk.red(`version '${err.wanted}' not found in npm registry\navailable versions:\n`)
+            spinner.fail(msg+err.versions.reverse().join(' | '));
+            throw err.code;
+        }
+        spinner.fail('Unexpected error');
+        throw new Error(err);
     }
     await fs.copy(tempDir+'/dist', targetDir);
     await fs.remove(tempDir);

index.js

@@ -1 +1 @@
-require('./cli')();
+require('./cli')().catch(console.error);

tests/test.js

@@ -24,6 +24,7 @@ const all_versions = [
 const cases = [
   null,
   "-r=latest",
+  "-r=7",
   "-r=7.2.0",
   "-r=v7.2.0",
   "-r=v7.2",
@@ -112,13 +113,26 @@ describe.each(cases)("Downloading %s", (version) => {
 
 describe("Errors", () => {
   test("Wrong version 6..2.3", async () => {//maybe create test.each() for more errors scenarios
-    const mockExit = jest.spyOn(process, "exit").mockImplementation(() => {});
     const version = "-r=6..2.3";
+    try{
+      await runCli(version);
+    }catch(err){
+      expect(err).toBe('ETARGET');
+    }finally{
+      await fs.remove(versionFolder(version));
+    }
+  });
+});
 
-    await runCli(version);
-
-    await fs.remove(versionFolder(version));
-    expect(mockExit).toHaveBeenCalledWith(1);
-    mockExit.mockRestore();
+describe("Unexpected errors", () => {
+  test("Unexpected error 6..2.3,7.2.3", async () => {//maybe create test.each() for more errors scenarios
+    const version = "-r=6..2.3,7.2.3";
+    try{
+      await runCli(version);
+    }catch(err){
+      expect(err).not.toBe('ETARGET');
+    }finally{
+      await fs.remove(versionFolder(version));
+    }
   });
 });