Skip to content

Commit 9f50052

Browse files
committed
BUG: Fix issue #37 invalid Controller port bind
Fix a bug where Controller deployment would bind same port as service from controller.service.tcpPorts, instead of targetPort. Thanks skaffille for reporting. MINOR: Update version to 1.6.3 and Controller to 1.4.8. Signed-off-by: Dinko Korunic <[email protected]>
1 parent 859bfcf commit 9f50052

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

kubernetes-ingress/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
apiVersion: v1
1616
name: kubernetes-ingress
17-
version: 1.6.2
17+
version: 1.6.3
1818
kubeVersion: ">=1.12.0-0"
1919
description: A Helm chart for HAProxy Kubernetes Ingress Controller
2020
keywords:
@@ -31,5 +31,5 @@ maintainers:
3131
3232
- name: Dinko Korunic
3333
34-
appVersion: 1.4.7
34+
appVersion: 1.4.8
3535
tillerVersion: ">=2.9.0"

kubernetes-ingress/templates/controller-deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ spec:
9696
{{- end }}
9797
{{- range .Values.controller.service.tcpPorts }}
9898
- name: {{ .name }}-tcp
99-
containerPort: {{ .port }}
99+
containerPort: {{ .targetPort }}
100100
protocol: TCP
101101
{{- end }}
102102
livenessProbe:

0 commit comments

Comments
 (0)