Skip to content

Commit c2ca908

Browse files
committed
MINOR: Add terminationGracePeriodSeconds to both HAProxy Chart and
Ingress Controller Chart. CI: Update Chart Testing to latest image and Kind to 0.9.0. Release HAProxy Chart 1.1.0 and Ingress Controller Chart 1.8.0. Signed-off-by: Dinko Korunic <[email protected]>
1 parent 16bf6b5 commit c2ca908

File tree

10 files changed

+17
-4
lines changed

10 files changed

+17
-4
lines changed

.circleci/install_charts.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ set -o errexit
44
set -o nounset
55
set -o pipefail
66

7-
readonly CT_VERSION=v3.0.0-beta.1
8-
readonly KIND_VERSION=v0.6.1
7+
readonly CT_VERSION=latest
8+
readonly KIND_VERSION=v0.9.0
99
readonly CLUSTER_NAME=chart-testing
1010
readonly REPO_ROOT="${REPO_ROOT:-$(git rev-parse --show-toplevel)}"
1111

haproxy/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
apiVersion: v1
1616
name: haproxy
17-
version: 1.0.1
17+
version: 1.1.0
1818
kubeVersion: ">=1.12.0-0"
1919
description: A Helm chart for HAProxy on Kubernetes
2020
keywords:

haproxy/templates/daemonset.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ spec:
4747
{{- end }}
4848
spec:
4949
serviceAccountName: {{ include "haproxy.serviceAccountName" . }}
50+
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
5051
{{- if $useHostNetwork }}
5152
hostNetwork: true
5253
{{- end }}

haproxy/templates/deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ spec:
4646
{{- end }}
4747
spec:
4848
serviceAccountName: {{ include "haproxy.serviceAccountName" . }}
49+
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
4950
securityContext:
5051
{{- toYaml .Values.podSecurityContext | nindent 8 }}
5152
{{- if .Values.dnsConfig }}

haproxy/values.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,10 @@ initContainers: []
5555
# securityContext:
5656
# privileged: true
5757

58+
## Pod termination grace period
59+
## ref: https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/
60+
terminationGracePeriodSeconds: 60
61+
5862
## Private Registry configuration
5963
## ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/
6064
imageCredentials:

kubernetes-ingress/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
apiVersion: v1
1616
name: kubernetes-ingress
17-
version: 1.7.0
17+
version: 1.8.0
1818
kubeVersion: ">=1.12.0-0"
1919
description: A Helm chart for HAProxy Kubernetes Ingress Controller
2020
keywords:

kubernetes-ingress/templates/controller-daemonset.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ spec:
5353
{{- end }}
5454
spec:
5555
serviceAccountName: {{ template "kubernetes-ingress.serviceAccountName" . }}
56+
terminationGracePeriodSeconds: {{ .Values.controller.terminationGracePeriodSeconds }}
5657
{{- if $useHostNetwork }}
5758
hostNetwork: true
5859
{{- end }}

kubernetes-ingress/templates/controller-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ spec:
5252
{{- end }}
5353
spec:
5454
serviceAccountName: {{ template "kubernetes-ingress.serviceAccountName" . }}
55+
terminationGracePeriodSeconds: {{ .Values.controller.terminationGracePeriodSeconds }}
5556
{{- if .Values.controller.dnsConfig }}
5657
dnsConfig:
5758
{{ toYaml .Values.controller.dnsConfig | indent 8 }}

kubernetes-ingress/templates/default-backend-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ spec:
7575
{{- toYaml . | nindent 8 }}
7676
{{- end }}
7777
serviceAccountName: {{ template "kubernetes-ingress.defaultBackend.serviceAccountName" . }}
78+
terminationGracePeriodSeconds: 60
7879
{{- with .Values.defaultBackend.tolerations }}
7980
tolerations:
8081
{{- toYaml . | nindent 8 }}

kubernetes-ingress/values.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,10 @@ controller:
6868
# securityContext:
6969
# privileged: true
7070

71+
## Pod termination grace period
72+
## ref: https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/
73+
terminationGracePeriodSeconds: 60
74+
7175
## Private Registry configuration
7276
## ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/
7377
imageCredentials:

0 commit comments

Comments
 (0)