Skip to content

Commit 2e9095c

Browse files
Update test.yml - don't run remote tests for now
Mauricio brought up a very valid security risk associated w/ running our e2e integration tests in github CI. --> Removed our github secrets, and therefore need to not run our deployment e2e testing in CI. https://salesforce-internal.slack.com/archives/C06E0A422BA/p1750286355664199 Signed-off-by: Hillary Sanders <[email protected]>
1 parent 92b939b commit 2e9095c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ jobs:
4242
# 2 - Deploy this PR to a temp Heroku app and run tests against deployed app (in addition to 'local')
4343
###########################################################################
4444
remote:
45+
if: false # These e2d depployment tests are super useful, but require you to add a HEROKU_API_KEY to your repo's actions secrets.
4546
runs-on: ubuntu-latest
4647
env:
4748
HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }}
@@ -136,4 +137,4 @@ jobs:
136137
- name: Destroy Heroku app after test
137138
if: always()
138139
run: |
139-
heroku apps:destroy --app $APP_NAME --confirm $APP_NAME
140+
heroku apps:destroy --app $APP_NAME --confirm $APP_NAME

0 commit comments

Comments
 (0)