From 2e9095c4cd554625cda9372c352d9c3c182f0644 Mon Sep 17 00:00:00 2001 From: Hillary Sanders Date: Wed, 18 Jun 2025 16:13:40 -0700 Subject: [PATCH] Update test.yml - don't run remote tests for now Mauricio brought up a very valid security risk associated w/ running our e2e integration tests in github CI. --> Removed our github secrets, and therefore need to not run our deployment e2e testing in CI. https://salesforce-internal.slack.com/archives/C06E0A422BA/p1750286355664199 Signed-off-by: Hillary Sanders --- .github/workflows/test.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index be91f08..977a77a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -42,6 +42,7 @@ jobs: # 2 - Deploy this PR to a temp Heroku app and run tests against deployed app (in addition to 'local') ########################################################################### remote: + if: false # These e2d depployment tests are super useful, but require you to add a HEROKU_API_KEY to your repo's actions secrets. runs-on: ubuntu-latest env: HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }} @@ -136,4 +137,4 @@ jobs: - name: Destroy Heroku app after test if: always() run: | - heroku apps:destroy --app $APP_NAME --confirm $APP_NAME \ No newline at end of file + heroku apps:destroy --app $APP_NAME --confirm $APP_NAME