Skip to content

Commit a2fc693

Browse files
committed
log that JDBC batching is enabled at startup
1 parent 123bb8a commit a2fc693

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

hibernate-core/src/main/java/org/hibernate/engine/jdbc/batch/JdbcBatchLogging.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ public interface JdbcBatchLogging extends BasicLogger {
3838
Logger BATCH_LOGGER = Logger.getLogger( NAME );
3939
JdbcBatchLogging BATCH_MESSAGE_LOGGER = Logger.getMessageLogger( MethodHandles.lookup(), JdbcBatchLogging.class, NAME );
4040

41+
@LogMessage(level = INFO)
42+
@Message(id=100501, value = "Automatic JDBC statement batching enabled (maximum batch size %s)")
43+
void batchingEnabled(int batchSize);
44+
4145
@LogMessage(level = WARN)
4246
@Message(id = 100502, value = "Unable to release batch statement")
4347
void unableToReleaseBatchStatement();

hibernate-core/src/main/java/org/hibernate/engine/jdbc/batch/internal/BatchBuilderImpl.java

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
import static java.util.Collections.emptyList;
2222
import static org.hibernate.engine.jdbc.batch.JdbcBatchLogging.BATCH_LOGGER;
23+
import static org.hibernate.engine.jdbc.batch.JdbcBatchLogging.BATCH_MESSAGE_LOGGER;
2324

2425
/**
2526
* A builder for {@link Batch} instances.
@@ -36,13 +37,10 @@ public class BatchBuilderImpl implements BatchBuilder {
3637
* on {@link #buildBatch}
3738
*/
3839
public BatchBuilderImpl(int globalBatchSize) {
39-
if ( BATCH_LOGGER.isTraceEnabled() ) {
40-
BATCH_LOGGER.tracef(
41-
"Using standard BatchBuilder (%s)",
42-
globalBatchSize
43-
);
40+
if ( globalBatchSize > 1 ) {
41+
BATCH_MESSAGE_LOGGER.batchingEnabled( globalBatchSize );
4442
}
45-
43+
BATCH_LOGGER.trace( "Using standard BatchBuilder");
4644
this.globalBatchSize = globalBatchSize;
4745
}
4846

@@ -56,11 +54,11 @@ public Batch buildBatch(
5654
Integer explicitBatchSize,
5755
Supplier<PreparedStatementGroup> statementGroupSupplier,
5856
JdbcCoordinator jdbcCoordinator) {
59-
final int batchSize = explicitBatchSize == null
60-
? globalBatchSize
61-
: explicitBatchSize;
57+
final int batchSize =
58+
explicitBatchSize == null
59+
? globalBatchSize
60+
: explicitBatchSize;
6261
assert batchSize > 1;
63-
6462
return new BatchImpl( key, statementGroupSupplier.get(), batchSize, jdbcCoordinator );
6563
}
6664

0 commit comments

Comments
 (0)