HBX-3194: Remove unused Class parameter from method EntityModelDetector#visitProperty()

Signed-off-by: Koen Aers <[email protected]>

Author: koentsje

orm/src/main/java/org/hibernate/tool/internal/export/lint/BadCachingDetector.java

@@ -13,12 +13,12 @@ public String getName() {
 	}	
 
 	@Override
-	protected void visitProperty(PersistentClass clazz, Property property, IssueCollector collector) {
+	protected void visitProperty(Property property, IssueCollector collector) {
 		Value value = property.getValue();
 
 		if(value instanceof Collection) {
-			Collection col = (Collection) value;
-			if(col.getCacheConcurrencyStrategy()!=null) { // caching is enabled
+            Collection col = (Collection) value;
+            if(col.getCacheConcurrencyStrategy()!=null) { // caching is enabled
 				if (!col.getElement().isSimpleValue()) {
 					String entityName = (String) col.getElement().accept( new EntityNameFromValueVisitor() );
 

orm/src/main/java/org/hibernate/tool/internal/export/lint/EntityModelDetector.java

@@ -1,17 +1,14 @@
 package org.hibernate.tool.internal.export.lint;
 
-import java.util.Iterator;
-
 import org.hibernate.mapping.PersistentClass;
 import org.hibernate.mapping.Property;
 
 public abstract class EntityModelDetector extends Detector {
 
 	public void visit(IssueCollector collector) {
-		for (Iterator<PersistentClass> iter = getMetadata().getEntityBindings().iterator(); iter.hasNext();) {
-			PersistentClass clazz = iter.next();
-			this.visit(clazz, collector);				
-		}
+        for (PersistentClass clazz : getMetadata().getEntityBindings()) {
+            this.visit(clazz, collector);
+        }
 	}
 
 	protected void visit(PersistentClass clazz, IssueCollector collector) {
@@ -20,13 +17,13 @@ protected void visit(PersistentClass clazz, IssueCollector collector) {
 
 	private void visitProperties(PersistentClass clazz, IssueCollector collector) {
 		if(clazz.hasIdentifierProperty()) {
-			this.visitProperty(clazz, clazz.getIdentifierProperty(), collector);								
+			this.visitProperty(clazz.getIdentifierProperty(), collector);
 		}
 		for (Property property : clazz.getProperties()) {
-			this.visitProperty(clazz, property, collector);							
+			this.visitProperty(property, collector);
 		}
 	}
 
-	protected abstract void visitProperty(PersistentClass clazz, Property property, IssueCollector collector);
+	protected abstract void visitProperty(Property property, IssueCollector collector);
 
 }

orm/src/main/java/org/hibernate/tool/internal/export/lint/InstrumentationDetector.java

@@ -49,26 +49,23 @@ protected void visit(PersistentClass clazz, IssueCollector collector) {
 		} else if(enhanceEnabled){
 			Class<?>[] interfaces = mappedClass.getInterfaces();
 			boolean enhanced = false;
-			for (int i = 0; i < interfaces.length; i++) {
-				Class<?> intface = interfaces[i];	
-				if(intface.getName().equals(Managed.class.getName())) {
-					enhanced = true;
-				} 							
-			}
+            for (Class<?> intface : interfaces) {
+                if (intface.getName().equals(Managed.class.getName())) {
+                    enhanced = true;
+                    break;
+                }
+            }
 
-			if (enhanceEnabled && !enhanced) {
+			if (!enhanced) {
 				collector.reportIssue( new Issue("LAZY_NOT_INSTRUMENTED", Issue.HIGH_PRIORITY, "'" + clazz.getEntityName() + "' has lazy='false', but its class '" + mappedClass.getName() + "' has not been instrumented with javaassist") );
 				return;
-			} else {
-				// unknown bytecodeprovider...can't really check for that.
 			}
 
 		}
 	}
 
 	@Override
 	protected void visitProperty(
-			PersistentClass clazz, 
 			Property property,
 			IssueCollector collector) {
 	}

orm/src/main/java/org/hibernate/tool/internal/export/lint/ShadowedIdentifierDetector.java

@@ -1,6 +1,5 @@
 package org.hibernate.tool.internal.export.lint;
 
-import org.hibernate.mapping.PersistentClass;
 import org.hibernate.mapping.Property;
 
 public class ShadowedIdentifierDetector extends EntityModelDetector {
@@ -10,7 +9,7 @@ public String getName() {
 	}
 
 	@Override
-	protected void visitProperty(PersistentClass clazz, Property property, IssueCollector collector) {
+	protected void visitProperty(Property property, IssueCollector collector) {
 		if(property.getName().equals("id")) {
 			if (property != property.getPersistentClass().getIdentifierProperty()) {
 				collector.reportIssue(new Issue("ID_SHADOWED", Issue.LOW_PRIORITY, property.getPersistentClass().getEntityName() + " has a normal property named 'id'. This can cause issues since HQL queries will always interpret 'id' as the identifier and not the concrete property"));