Skip to content
This repository was archived by the owner on Jul 31, 2019. It is now read-only.

add a windows workaround for getting chrome version #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add a windows workaround for getting chrome version #7

wants to merge 1 commit into from

Conversation

@cderv
Copy link

@cderv cderv commented Nov 11, 2018 •
edited
Loading

This follows a discussion and closes #6 by offering a workaround on windows based on a powershell command.

Some questions:

  • Is powershell always available on windows or should there be a fail safe (Trycatch ?)
  • I don't know how to add some tests for OS specific stuff like that. An idea ?

This change is Reviewable

This was referenced Nov 11, 2018
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

On windows, getting chrome version opens browser and does not work.

1 participant

@cderv