Cache app labels for faster app picking

Author: pimterry

app/src/main/java/tech/httptoolkit/android/AppLabelCache.kt

@@ -0,0 +1,16 @@
+package tech.httptoolkit.android
+
+import android.content.pm.ApplicationInfo
+import android.content.pm.PackageManager
+
+object AppLabelCache {
+
+    private val cache = HashMap<String, String>() // PackageName -> Label
+
+    fun getAppLabel(packageManager: PackageManager, applicationInfo: ApplicationInfo): String {
+        return cache.getOrPut(applicationInfo.packageName) {
+            applicationInfo.loadLabel(packageManager).toString()
+        }
+    }
+
+}

app/src/main/java/tech/httptoolkit/android/ApplicationListActivity.kt

@@ -77,7 +77,7 @@ class ApplicationListActivity : AppCompatActivity(), SwipeRefreshLayout.OnRefres
 
     private fun matchesFilters(app: PackageInfo): Boolean {
         val appInfo = app.applicationInfo
-        val appLabel = appInfo.loadLabel(packageManager)
+        val appLabel = AppLabelCache.getAppLabel(packageManager, appInfo)
         val isSystemApp = appInfo.flags and ApplicationInfo.FLAG_SYSTEM == 1
 
         return (textFilter.isEmpty() || appLabel.contains(textFilter, true)) && // Filter by name
@@ -100,8 +100,8 @@ class ApplicationListActivity : AppCompatActivity(), SwipeRefreshLayout.OnRefres
     private suspend fun loadAllApps(): List<PackageInfo> =
         withContext(Dispatchers.IO) {
             return@withContext packageManager.getInstalledPackages(PackageManager.GET_META_DATA).apply {
-                sortBy {
-                    it.applicationInfo.loadLabel(packageManager).toString().toUpperCase(
+                sortBy { pkg ->
+                    AppLabelCache.getAppLabel(packageManager, pkg.applicationInfo).toUpperCase(
                         Locale.getDefault()
                     )
                 }

app/src/main/java/tech/httptoolkit/android/ApplicationListAdapter.kt

@@ -37,11 +37,12 @@ class ApplicationListAdapter(
             }
         }
 
-        fun bind(appInfo: PackageInfo) {
-            itemView.row_app_icon_image.setImageDrawable(appInfo.applicationInfo.loadIcon(packageManager))
-            itemView.row_app_name.text = appInfo.applicationInfo.loadLabel(packageManager)
-            itemView.row_app_package_name.text = appInfo.packageName
-            itemView.row_app_switch.isChecked = isAppWhitelisted(appInfo)
+        fun bind(packageInfo: PackageInfo) {
+            val appInfo = packageInfo.applicationInfo
+            itemView.row_app_icon_image.setImageDrawable(appInfo.loadIcon(packageManager))
+            itemView.row_app_name.text = AppLabelCache.getAppLabel(packageManager, appInfo)
+            itemView.row_app_package_name.text = packageInfo.packageName
+            itemView.row_app_switch.isChecked = isAppWhitelisted(packageInfo)
         }
     }
 }