Conversation
The llama 3.1 tool calling template says "orginal user question" instead of the "original user question". Unless it's the actual prompt pattern the model is trained with, this should affect the tool use performance; and I see this typo spreading to other tutorials and tools using Llama 3.1
Member
|
Hi @wizzard0! Actually, the typo is also present in the official documentation (see Step 3 in the JSON-based tool calling section). I doubt that the system prompt has to be supplied verbatim like that and I'd prefer to have the typo fixed, but I haven't really tested it comprehensively. Have you observed differences one way or another? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The llama 3.1 tool calling template says "orginal user question" instead of the "original user question".
Unless it's the actual prompt pattern the model is trained with, this should affect the tool use performance; and I see this typo spreading to other tutorials and tools using Llama 3.1