fix: subscriptions historical filtering

- a subscription always has a transport

Signed-off-by: Enrique Lacal <[email protected]>

Author: EnriqueL8

internal/events/event_manager.go

@@ -311,8 +311,6 @@ func (em *eventManager) QueueBatchRewind(batchID *fftypes.UUID) {
 }
 
 func (em *eventManager) FilterHistoricalEventsOnSubscription(ctx context.Context, events []*core.EnrichedEvent, sub *core.Subscription) ([]*core.EnrichedEvent, error) {
-	// Transport must be provided for validation, but we're not using it for event delivery so fake the transport
-	sub.Transport = "websockets"
 	subscriptionDef, err := em.subManager.parseSubscriptionDef(ctx, sub)
 	if err != nil {
 		return nil, err

internal/events/event_manager_test.go

@@ -664,6 +664,7 @@ func TestEventFilterOnSubscriptionMatchesEventType(t *testing.T) {
 	}
 
 	subscription := &core.Subscription{
+		Transport: "websockets",
 		Filter: core.SubscriptionFilter{
 			Events: core.EventTypeIdentityConfirmed.String(),
 		},